testcontainers-java icon indicating copy to clipboard operation
testcontainers-java copied to clipboard

Set Elasticsearch default heap size to 2GB

Open DKarim opened this issue 3 years ago • 1 comments

Proposed fix for https://github.com/testcontainers/testcontainers-java/issues/5393

  • Set default and max heap size for Elastic Search container to 2g
  • Add a method to override this default value

DKarim avatar May 28 '22 12:05 DKarim

Hey @DKarim, will you take another look regarding the feedback, or shall we take care of incorporating this change?

kiview avatar Aug 08 '22 13:08 kiview

Hi @DKarim and reviewers.

Hope I am not intruding - I thought I would help address some of the comments on this PR as it seems like @DKarim is busy. I've created a separate PR (https://github.com/testcontainers/testcontainers-java/pull/5684) with the new changes.

aidando73 avatar Aug 13 '22 07:08 aidando73

Thanks, @REslim30. WDYT @DKarim, do you want to follow up, or should we continue with the other PR?

kiview avatar Aug 15 '22 08:08 kiview

Thanks @DKarim ! Closing it because #5684 was merged.

eddumelendez avatar Aug 26 '22 00:08 eddumelendez