testcontainers-java icon indicating copy to clipboard operation
testcontainers-java copied to clipboard

Add Consul module

Open julb opened this issue 3 years ago • 6 comments

julb avatar Nov 17 '21 14:11 julb

Hi @julb, thanks a lot for contributing this module.

Looking at the logic around runInitCommands(), it seems that this module makes using Consul with Testcontainers considerably easier, so theoretically we can imagine this becoming an incubating module.

However, we are currently lacking the capacity to review and merge PRs for new modules, so I can't promise when we will be able to get to it. This does not mean, that we don't appreciate your contribution. We are currently in the process to rework our current approach around modules, to make it easier for the community to contribute them.

In case you are interested in getting it out to users as early as possible, you can always consider publishing it in your own repo (this is in no way an indication, that we don't want to add it to our repo).

kiview avatar Nov 17 '21 15:11 kiview

Hey @eddumelendez It is updated. Thanks for your feedback!

julb avatar Jul 28 '22 13:07 julb

@eddumelendez @kiview all remarks addressed! Thanks a lot.

julb avatar Jul 29 '22 07:07 julb

@julb can you please add consul to

  • .github/ISSUE_TEMPLATE/bug_report.yaml
  • .github/ISSUE_TEMPLATE/enhancement.yaml
  • .github/ISSUE_TEMPLATE/feature.yaml
  • .github/dependabot.yml
  • .github/labeler.yml
Index: .github/ISSUE_TEMPLATE/bug_report.yaml
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/.github/ISSUE_TEMPLATE/bug_report.yaml b/.github/ISSUE_TEMPLATE/bug_report.yaml
--- a/.github/ISSUE_TEMPLATE/bug_report.yaml	(revision c9fc9afff3c13bdf7c6f7762ab8815ed91550399)
+++ b/.github/ISSUE_TEMPLATE/bug_report.yaml	(revision 95124487415f8ffad3a06df54d6081f4dd6e269d)
@@ -17,6 +17,7 @@
         - Azure
         - Cassandra
         - Clickhouse
+        - Consul
         - Couchbase
         - DB2
         - Dynalite
Index: .github/ISSUE_TEMPLATE/enhancement.yaml
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/.github/ISSUE_TEMPLATE/enhancement.yaml b/.github/ISSUE_TEMPLATE/enhancement.yaml
--- a/.github/ISSUE_TEMPLATE/enhancement.yaml	(revision c9fc9afff3c13bdf7c6f7762ab8815ed91550399)
+++ b/.github/ISSUE_TEMPLATE/enhancement.yaml	(revision 95124487415f8ffad3a06df54d6081f4dd6e269d)
@@ -17,6 +17,7 @@
         - Azure
         - Cassandra
         - Clickhouse
+        - Consul
         - Couchbase
         - DB2
         - Dynalite
Index: .github/ISSUE_TEMPLATE/feature.yaml
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/.github/ISSUE_TEMPLATE/feature.yaml b/.github/ISSUE_TEMPLATE/feature.yaml
--- a/.github/ISSUE_TEMPLATE/feature.yaml	(revision c9fc9afff3c13bdf7c6f7762ab8815ed91550399)
+++ b/.github/ISSUE_TEMPLATE/feature.yaml	(revision 95124487415f8ffad3a06df54d6081f4dd6e269d)
@@ -17,6 +17,7 @@
         - Azure
         - Cassandra
         - Clickhouse
+        - Consul
         - Couchbase
         - DB2
         - Dynalite
Index: .github/dependabot.yml
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/.github/dependabot.yml b/.github/dependabot.yml
--- a/.github/dependabot.yml	(revision c9fc9afff3c13bdf7c6f7762ab8815ed91550399)
+++ b/.github/dependabot.yml	(revision 95124487415f8ffad3a06df54d6081f4dd6e269d)
@@ -43,6 +43,11 @@
       interval: "monthly"
     open-pull-requests-limit: 10
   - package-ecosystem: "gradle"
+    directory: "/modules/consul"
+    schedule:
+      interval: "monthly"
+    open-pull-requests-limit: 10
+  - package-ecosystem: "gradle"
     directory: "/modules/couchbase"
     schedule:
       interval: "monthly"
Index: .github/labeler.yml
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/.github/labeler.yml b/.github/labeler.yml
--- a/.github/labeler.yml	(revision c9fc9afff3c13bdf7c6f7762ab8815ed91550399)
+++ b/.github/labeler.yml	(revision 95124487415f8ffad3a06df54d6081f4dd6e269d)
@@ -15,6 +15,8 @@
   - modules/clickhouse/*
 "modules/cockroachdb":
   - modules/cockroachdb/*
+"modules/consul":
+  - modules/consul/*
 "modules/couchbase":
   - modules/couchbase/*
 "modules/db2":

eddumelendez avatar Aug 04 '22 20:08 eddumelendez

@eddumelendez @kiview done! Thanks for your reviews and your time.

julb avatar Aug 05 '22 07:08 julb

Thanks @julb, we will merge once we internally decided on how to proceed with package names for container modules 🙂

kiview avatar Aug 05 '22 08:08 kiview

Thanks @julb ! PR has been merged and now we have a consul module!

eddumelendez avatar Aug 15 '22 14:08 eddumelendez

OMG! Thanks a lot for your support, that's awesome !! Looking forward for the official release!

julb avatar Aug 15 '22 19:08 julb