testcontainers-dotnet icon indicating copy to clipboard operation
testcontainers-dotnet copied to clipboard

[Enhancement]: Refactor the `IImage` properties (align with DSL)

Open HofmeisterAn opened this issue 2 years ago • 3 comments

Problem

The IImage interface does not follow the correct naming conventions.

Solution

The interface should use the following properties: Registry, Repository, Tag, FullName.

Benefit

Align with the DSL.

Alternatives

-

Would you like to help contributing this enhancement?

Yes

HofmeisterAn avatar Jan 19 '23 11:01 HofmeisterAn

Has this been resolved with #729?

jacobjmarks avatar Jul 28 '23 03:07 jacobjmarks

No, it is something we still need to change. I have not touched it because it introduces breaking changes. To align with the Docker DSL we need to rename (adjust) the properties, e.g.

Actual Expected
Registry - myregistryhost:5000
Repository myregistryhost:5000/fedora fedora/httpd
Name httpd -
Tag version1.0 version1.0
GetHostname() myregistryhost:5000 -

HofmeisterAn avatar Jul 28 '23 18:07 HofmeisterAn

Happy to work on this if it's something you'd like to see done, despite the breaking changes.

jacobjmarks avatar Jul 29 '23 04:07 jacobjmarks