testcontainers-dotnet icon indicating copy to clipboard operation
testcontainers-dotnet copied to clipboard

Add Db2 module

Open kevin0x90 opened this issue 1 year ago • 2 comments

What does this PR do?

Adds a module to use Db2 with testcontainers.

How to test this PR

Automated tests have been added to the project that verify startup and database connectivity.

kevin0x90 avatar Aug 20 '24 08:08 kevin0x90

Deploy Preview for testcontainers-dotnet ready!

Name Link
Latest commit 61bfd3d769fb6556a37fbacb9e0b4772f78def4f
Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/66c45ad21aeb910008c69a02
Deploy Preview https://deploy-preview-1237--testcontainers-dotnet.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Aug 20 '24 08:08 netlify[bot]

Deploy Preview for testcontainers-dotnet ready!

Name Link
Latest commit 7fc391bd0350d75e8684ed8bddc33b1c195f213b
Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/67ae0b8b9263f000080ebcee
Deploy Preview https://deploy-preview-1237--testcontainers-dotnet.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Aug 20 '24 08:08 netlify[bot]

Thanks for updating the PR. I've updated the remaining parts. The PR looks good! If you're okay with it, I'm happy to merge it.

I just have one final question: Does it make sense to set any of these configurations as defaults (in Init()) to improve startup performance (or improves development experience)?

.WithEnvironment("TO_CREATE_SAMPLEDB", "false")
.WithEnvironment("PERSISTENT_HOME", "true")
.WithEnvironment("REPODB", "false")
.WithEnvironment("BLU", "false")
.WithEnvironment("HADR_ENABLED", "false")
.WithEnvironment("ARCHIVE_LOGS", "false")
.WithEnvironment("AUTOCONFIG", "false")

Thank you very much for finishing up the PR for the parts I had not addressed yet. Yes it would have some positive effect regarding startup performance but in general the official image takes quite some time to startup even with the optimizations so I’m not sure if it makes a big difference.

kevin0x90 avatar Feb 15 '25 21:02 kevin0x90