terraform-provider-rhcs icon indicating copy to clipboard operation
terraform-provider-rhcs copied to clipboard

OCM-18657 | feat: Add external auth provider resource with validation

Open gdbranco opened this issue 1 month ago • 3 comments

  • Add comprehensive external auth provider resource structure
  • Implement schema with full validation including HTTPS URLs, client secrets
  • Add custom validation for client ID/secret combinations
  • Create complete state structures following backend API model
  • Add subsystem tests for validation scenarios
  • Register resource in provider
  • Implement placeholder CRUD operations (to be completed in OCM-18658)

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story (OCM-xxxx): Fixes #OCM-18657

Change type

  • [x] New feature
  • [ ] Bug fix
  • [ ] Build
  • [ ] CI
  • [x] Documentation
  • [ ] Performance
  • [ ] Refactor
  • [ ] Style
  • [ ] Unit tests
  • [x] Subsystem tests

Checklist

  • [ ] Subject and description added to both, commit and PR.
  • [ ] Relevant issues have been referenced.

gdbranco avatar Oct 01 '25 21:10 gdbranco

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] avatar Oct 01 '25 21:10 openshift-ci[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign vkareh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Oct 01 '25 21:10 openshift-ci[bot]

@gdbranco: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit a3a0bbe11fa5830309708c46c79c189892642c35 link true /test unit
ci/prow/e2e-presubmits-rosa-sts-private-critical-high-presubmit a3a0bbe11fa5830309708c46c79c189892642c35 link true /test e2e-presubmits-rosa-sts-private-critical-high-presubmit
ci/prow/e2e-presubmits-rosa-hcp-advanced-critical-high-presubmit a3a0bbe11fa5830309708c46c79c189892642c35 link true /test e2e-presubmits-rosa-hcp-advanced-critical-high-presubmit
ci/prow/e2e-presubmits-rosa-sts-advanced-critical-high-presubmit a3a0bbe11fa5830309708c46c79c189892642c35 link true /test e2e-presubmits-rosa-sts-advanced-critical-high-presubmit
ci/prow/e2e-presubmits-rosa-hcp-private-critical-high-presubmit a3a0bbe11fa5830309708c46c79c189892642c35 link true /test e2e-presubmits-rosa-hcp-private-critical-high-presubmit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Oct 14 '25 13:10 openshift-ci[bot]