terraform-provider-rhcs icon indicating copy to clipboard operation
terraform-provider-rhcs copied to clipboard

OCM-12705 | feat: Add min/max replica values to docs

Open den-rgb opened this issue 11 months ago • 3 comments

What this PR does / why we need it: Adding Min/Max info to machinepool replicas for classic and hcp clusters + max kubelet config pod pid limits Which issue(s) this PR fixes OCM-12705

Change type

  • [ ] New feature
  • [ ] Bug fix
  • [ ] Build
  • [ ] CI
  • [x] Documentation
  • [ ] Performance
  • [ ] Refactor
  • [ ] Style
  • [ ] Unit tests
  • [ ] Subsystem tests

Checklist

  • [ ] Subject and description added to both, commit and PR.
  • [ ] Relevant issues have been referenced.

den-rgb avatar Dec 06 '24 11:12 den-rgb

@den-rgb @gdbranco After internal discussion it was deemed that listing the exact requirements within the TF docs and/or data source is not favored. It will be cumbersome to manage if any of these values get updated. Instead it would be best if we link / provide URL to the official openshift document showing the requirements.

davidleerh avatar Dec 06 '24 16:12 davidleerh

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign vkareh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Dec 17 '24 13:12 openshift-ci[bot]

@den-rgb: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-presubmits-rosa-sts-advanced-critical-high-presubmit a7509ff30dc194f7c4192217f64838470e9da25b link true /test e2e-presubmits-rosa-sts-advanced-critical-high-presubmit
ci/prow/e2e-presubmits-rosa-hcp-advanced-critical-high-presubmit a7509ff30dc194f7c4192217f64838470e9da25b link true /test e2e-presubmits-rosa-hcp-advanced-critical-high-presubmit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Dec 18 '24 15:12 openshift-ci[bot]