terraform-google-bigquery icon indicating copy to clipboard operation
terraform-google-bigquery copied to clipboard

chore: Mark some table attributes as optional

Open darwin67 opened this issue 2 years ago • 5 comments

Summary

This change made the following attributes optional.

  • time_partitioning
  • range_partitioning
  • expiration_time
  • labels

It's completely valid (and have legitimate reasons to) not to provide the attributes in the google_bigquery_table resource.

Currently, these attributes are treated as required and cause the plan, apply to fail if not provided.

darwin67 avatar Sep 15 '23 20:09 darwin67

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Sep 15 '23 20:09 google-cla[bot]

@davenportjw @g-awmalik @bharathkkb pinging for awareness.

darwin67 avatar Oct 20 '23 17:10 darwin67

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

github-actions[bot] avatar Jan 28 '24 23:01 github-actions[bot]

not stale

darwin67 avatar Jan 29 '24 05:01 darwin67

@davenportjw @shanecglass

darwin67 avatar Jan 29 '24 05:01 darwin67

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

github-actions[bot] avatar Mar 29 '24 23:03 github-actions[bot]