terraform-example-foundation

terraform-example-foundation copied to clipboard

remove unecessary variables in network-dual-svpc/shared

2

On run `grep` to show variables used in folder I realize that not always in declaration is used  This PR remove unnecessary variable (You can check that has 9...

guissalustiano

Reviewed executing all steps using Jenkins instead of Cloud Build: - Fixed instructions - Fixed Jenkins Agent setup script to install wget to download terraform and install terraform-tools using apt...

felipecrescencio-cit

When deploying the step [5-app-infra](https://github.com/terraform-google-modules/terraform-example-foundation/tree/master/5-app-infra) the bu1-example-app project .gitignore file is missing. We should have this file configured otherwhise it might cause errors when deploying it.

mauro-cit

No file diectory issue

1

### TL;DR ### TL;DR Error: External Program Execution Failed │ │ with module.build_terraform_image.data.external.env_override[0], │ on .terraform/modules/build_terraform_image/main.tf line 73, in data "external" "env_override": │ 73: program = ["${path.module}/scripts/check_env.sh"] │ │ The...

vivek-ins

Try testing only one env in e2e build

1

### TL;DR Between overall validate and usage of base_env, even deploying 1 env should given us expected e2e confidence. @daniel-cit mentioned an improvement of 30-40 mins and we can likely...

bharathkkb

5-app-infra README statement about branches

3

### TL;DR 5-app-infra/business_unit_1/ has 3 folders each with their own main.tf which should have independent resource management in different pipelines 5-app-infra/business_unit_1/development 5-app-infra/business_unit_1/non-production 5-app-infra/business_unit_1/production However, the README instruction seems to suggest...

yyzh1

### TL;DR We should document cloudbuild BYOSA limitation like we do in workspace incase user is deploying on an existing org https://github.com/terraform-google-modules/terraform-google-bootstrap/tree/master/modules/tf_cloudbuild_workspace#notes ### Expected behavior _No response_ ### Observed behavior...

bharathkkb

Add a repo for bootstap

1

### TL;DR We should encourage storing bootstrap stage source code in a source repo similar to other stages to be managed by cloudbuild after bootstrap. ### Terraform Resources _No response_...

bharathkkb

There are some small things that could be improved regarding Terraform Service accounts, they are: - Add a text on step 0-bootstrap saying that you should perform the Project Quota...

mauro-cit

### TL;DR Can the repo be deployed multiple times into multiple 'parent_folder' in the same org? My suspicion is that it cannot, because the policies are applied org-wide, rather than...

rr4444