terraform-example-foundation icon indicating copy to clipboard operation
terraform-example-foundation copied to clipboard

Published 20 hours ago • verified publisher icon terraform-google-modules

Eliminate hardcoding of business_unit (1 & 2) in 4-Projects

Open mromascanu123 opened this issue 1 year ago • 1 comments

TL;DR

  • why hardcoded rather than passed via global config via their parameters
  • why subnet_ip_range hardcoded?

Terraform Resources

No response

Detailed design

Provide configurations via top-level global config or at least tfvar-based at the package level

Additional information

No response

mromascanu123 avatar Mar 12 '24 16:03 mromascanu123

stale bot timer restart - https://github.com/terraform-google-modules/terraform-example-foundation/blob/master/.github/workflows/stale.yml#L21

fmichaelobrien avatar Apr 11 '24 15:04 fmichaelobrien

Closing. Our working principal is that this is example code, and not a module. If something needs to be put in place only once, we won't create a variable. If something is used in multiple places, we will use a variable. May be fixed in #1226

sleighton2022 avatar May 29 '24 14:05 sleighton2022