terraform-aws-sns icon indicating copy to clipboard operation
terraform-aws-sns copied to clipboard

feat: Add SQS subscription option

Open castironclay opened this issue 3 years ago β€’ 3 comments

Description

Added resources to create SQS subscription when desired.

Similar PR - #29

Motivation and Context

Currently this module only created an SNS topic. I wanted the ability, using boolean, to create an optional subscription to SQS queues.

Breaking Changes

None

How Has This Been Tested?

  • [x] I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • [x] I have tested and validated these changes using one or more of the provided examples/* projects
  • [x] I have executed pre-commit run -a on my pull request

castironclay avatar Apr 03 '22 19:04 castironclay

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

github-actions[bot] avatar May 04 '22 00:05 github-actions[bot]

No responses for this?

castironclay avatar May 04 '22 00:05 castironclay

Thanks for your response @antonbabenko. I will work on incorporating those changes.

castironclay avatar May 04 '22 21:05 castironclay

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

github-actions[bot] avatar Oct 28 '22 00:10 github-actions[bot]

This PR was automatically closed because of stale in 10 days

github-actions[bot] avatar Nov 08 '22 00:11 github-actions[bot]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions[bot] avatar Dec 08 '22 02:12 github-actions[bot]