terraform-aws-lambda icon indicating copy to clipboard operation
terraform-aws-lambda copied to clipboard

feat: Set ECR force_delete argument to true

Open 1Mill opened this issue 3 years ago β€’ 0 comments

Description

Maintain behavior to force delete created aws_ecr_repository even if it contains images.

Motivation and Context

AWS v4.22.0 introduced a breaking change to the behavior of this module.

Previously, aws_ecr_repository resources would always be destroyed, even if they contained images. Now, aws_ecr_repository resources are only destroyed if either (a) the repository is completely empty of images or (b) force_delete is set to true.

This PR sets force_delete to true so that any created aws_ecr_repository resource is always successfully destroyed on terraform destroy to maintain the existing behavior of this module.

Breaking Changes

  • Requires aws >= 4.22.0

How Has This Been Tested?

  • [x] I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • [x] I have tested and validated these changes using one or more of the provided examples/* projects

1Mill avatar Aug 07 '22 04:08 1Mill