terraform-aws-cloudfront icon indicating copy to clipboard operation
terraform-aws-cloudfront copied to clipboard

Missing documentation and example for cache behavior parameters

Open catrielg opened this issue 1 year ago β€’ 3 comments

Description

In the module itself, you support the use of trusted_key_groups, trusted_signers, smooth_streaming and more for ordered and default cache behaviors. However the usage is missing from your "complete" example as well as the documentation .

catrielg avatar Apr 24 '24 12:04 catrielg

Good point! Please submit a PR if possible.

antonbabenko avatar Apr 24 '24 13:04 antonbabenko

I have submitted a PR for the same. The example uses use_forwaded_values and legacy settings

anantadurgaprasad avatar May 03 '24 12:05 anantadurgaprasad

A complete example shows many arguments, but it would be nearly impossible to maintain and very hard to understand if there were all of them and supplementary resources. That is why we show the most common ones.

Adding a smaller subset of features into a separate example (like in #143) does not make it easier because there is no way to identify which feature to include.

Let's stick to the current complete example and maybe extend arguments if they are very important and used often. smooth_streaming - is not important, but trusted_key_groups and trusted_signersare good to have in the examples/complete with all required supplementary resources (such as aws_cloudfront_key_group, aws_cloudfront_public_key).

antonbabenko avatar May 03 '24 13:05 antonbabenko

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

github-actions[bot] avatar Jun 03 '24 00:06 github-actions[bot]

This issue was automatically closed because of stale in 10 days

github-actions[bot] avatar Jun 13 '24 00:06 github-actions[bot]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions[bot] avatar Jul 13 '24 02:07 github-actions[bot]