tfx-addons icon indicating copy to clipboard operation
tfx-addons copied to clipboard

How about adding rcParams argument in ModelCardGenerator

Open jeongukjae opened this issue 2 years ago • 2 comments

For non-English projects, it is essential to change the font configs to render graphics properly. If cannot, the graphics in the model card looks as follows:

test

So, it could be great if ModelCardGenerator can accept the argument like 'matplotlib_rcparams'.

mc_gen = ModelCardGenerator(
  pushed_model=...,
  ...
  ...
  matplotlib_rcparams=json.dumps({
    "font.family": "NanumGothic",
    ...
  }),
)

mentioning code owners of ModelCardGenerator @codesue @hanneshapke

jeongukjae avatar Jul 31 '23 10:07 jeongukjae

Great idea! In addition to supporting other languages, it would be nice to be able to customize the plots.

codesue avatar Aug 03 '23 02:08 codesue

@codesue Oh, it would be great if that's possible. I think that is another topic, so I'm leaving that at https://github.com/tensorflow/model-card-toolkit/discussions/296

jeongukjae avatar Aug 03 '23 05:08 jeongukjae