tensorflow icon indicating copy to clipboard operation
tensorflow copied to clipboard

Fixes byte order for uint16 and bfloat variables based on endianness

Open vibhutisawant opened this issue 3 years ago • 5 comments
trafficstars

This PR fixes //tensorflow/python/lib/core:bfloat16_test test case on s390x arch.

Test case initially failed for s390x arch because the little_endian_uint16 and little_endian_bfloat variables were defined with byte order as little-endian. Updating the byte order to Big Endian fixes this test case on s390x. Added an "if guard" to handle the byte order of these variables based on endianness.

vibhutisawant avatar Jun 28 '22 06:06 vibhutisawant

@vibhutisawant, Could you please sign CLA. Thank you!

tilakrayal avatar Jun 28 '22 11:06 tilakrayal

Hi @tilakrayal I have been covered under corporate CLA(IBM). I see the CLA check in the PR has passed. Please let me know if something is missing. Thanks

vibhutisawant avatar Jun 29 '22 05:06 vibhutisawant

Hi @mattdangerw, could you please take a look? Thanks!

vibhutisawant avatar Jul 13 '22 10:07 vibhutisawant

Hi @wangpengmit could you please have a look at this PR? Thanks!

vibhutisawant avatar Aug 03 '22 09:08 vibhutisawant

Hi @cantonios Can you please review this PR ? Thank you!

gbaned avatar Aug 09 '22 13:08 gbaned