serving
serving copied to clipboard
tensorflow
Add shift to consume script name before passing to application
The Dockerfile entrypoint /usr/bin/tf_serving_entrypoint.sh calls tensorflow_model_server with "$@" which results in an error message from tensorflow_model_server that "/usr/bin/tf_serving_entrypoint.sh" is not a supported option. This is because "$@" passes the first parameter which is the name of the script itself. To resolve this simply add the shift command to consume the first argument and then pass "$@" to tensorflow_model_server.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
ℹ️ Googlers: Go here for more info.
the fix looks correct, but i am puzzled why the instructions here:
https://github.com/tensorflow/serving#serve-a-tensorflow-model-in-60-seconds
do not yield any error. do you know why?
This was awhile ago but IIRC I was troubleshooting other issues with my model and noticed this error in the logs. I don't think the error actually causes the process/container to fail. It simply complains that the first option is no good and moves onto the next one. But again, this was awhile ago so I'd have to run through it again and see what happens.