rust icon indicating copy to clipboard operation
rust copied to clipboard

migrate from random crate to rand

Open RealAdarsh opened this issue 3 years ago • 4 comments

Migrate from random crate to rand #378

RealAdarsh avatar Sep 12 '22 12:09 RealAdarsh

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Sep 12 '22 12:09 google-cla[bot]

Can you fix the test failures? The ./test-all script should succeed.

adamcrume avatar Sep 14 '22 01:09 adamcrume

Hello Adam, I am new to open-source, Could you please help me how to fix this? I could try fixing it.

RealAdarsh avatar Sep 14 '22 05:09 RealAdarsh

All the other places in the file that reference the random crate also need to be switched to the rand crate, and Cargo.toml needs to be updated. This isn't a simple find-and-replace, because the types and functions in the two crates aren't identical.

adamcrume avatar Sep 15 '22 02:09 adamcrume

This was fixed in https://github.com/tensorflow/rust/pull/384.

adamcrume avatar Nov 04 '22 02:11 adamcrume