Merge operation accepts only single input

[SamKG]

trafficstars

The Merge operation (https://www.tensorflow.org/api_docs/cc/class/tensorflow/ops/merge) should accept a list of inputs, and output the first received tensor. However, the rust binding (https://tensorflow.github.io/rust/tensorflow/ops/fn.merge.html) currently accepts only a single input (despite the input variable being named "inputs"). Digging through the source code, I found that Merge.build_impl internally also calls nd.add_input instead of nd.add_inputs (https://tensorflow.github.io/rust/src/tensorflow/ops/ops_impl.rs.html#57909)

Is there a way to pass multiple inputs using this api?

[dskkato]

ref #325

[adamcrume]

It looks like the problem is that we're ignoring number_attr on input_arg. This is an issue for any op that takes a list as an input.

[SamKG]

@adamcrume I'd be happy to take a stab at fixing this - any pointers on where to start? Is it as simple as using the add_inputs method I mentioned earlier?

[adamcrume]

This wouldn't be quite that straightforward. The code for the ops is generated by tensorflow-op-codegen/src/main.rs, and I think the fix is to change write_short_fn, write_build_fn, and write_build_impl_fn so that they use a slice of Outputs rather than a single Output for any input_arg where number_attr is set. Then the ops would need to be regenerated by running cargo run -- $PATH_TO_TENSORFLOW $PWD/.. from the tensorflow-op-codegen folder.

[Corallus-Caninus]

Does the below build_instance method close this?

https://tensorflow.github.io/rust/tensorflow/ops/struct.Merge.html