recommenders icon indicating copy to clipboard operation
recommenders copied to clipboard

Fix: extra negatives causes shape mismatch in FactorizedTopK metrics

Open patrickorlando opened this issue 2 years ago • 1 comments

The Problem

The Retrieval task already slices the candidate_embeddings tensor to remove extra negatives, but it doesn't do the same for the candidate_ids. This leads to a shape mismatch when calculating the FactorizedTopK metrics, if also handling accidental hits.

patrickorlando avatar Feb 23 '23 12:02 patrickorlando

Thanks for providing this fix. I also noticed this issue. 👍

caesarjuly avatar Mar 15 '23 23:03 caesarjuly