java icon indicating copy to clipboard operation
java copied to clipboard

Published 20 hours ago • verified publisher icon tensorflow

Apply spotless to generated files, exclude c api files

Open rnett opened this issue 4 years ago • 2 comments
trafficstars

Does what it says in the title. I can include the C API files if you want, but most of them (especially the presets) have special formatting by @saudet and I'm not sure if we want to override that.

rnett avatar Jul 30 '21 19:07 rnett

Also, when I run generation locally I get a bunch of new op classes like CacheDatasetV2 that are in ops.pb but don't seem to be generated in master, can anyone reproduce this? Did we at some point not push the new ops?

rnett avatar Jul 30 '21 20:07 rnett

I also added a .gitattributes to set the line endings of most files to LF, since I was running into issues with it w/ the formatter when switching between Windows and Linux. Most of the generation code assumes that anyways.

rnett avatar Jul 31 '21 02:07 rnett