addons icon indicating copy to clipboard operation
addons copied to clipboard

Benchmark test for rrelu fails on windows

Open seanpmorgan opened this issue 5 years ago • 3 comments

Benchmark op fails for a median_delta of 0 in windows testing. Marking it as a SkipTest until resolved.

File "\\?\C:\Users\RUNNER~1\AppData\Local\Temp\Bazel.runfiles_e847arzc\runfiles\__main__\tensorflow_addons\activations\rrelu_test.py", line 88, in benchmarkRreluOp
    self.run_op_benchmark(sess, result.op, min_iters=25)
  File "C:\hostedtoolcache\windows\Python\3.7.5\x64\lib\site-packages\tensorflow_core\python\platform\benchmark.py", line 389, in run_op_benchmark
    "throughput": mbs / median_delta
ZeroDivisionError: float division by zero

seanpmorgan avatar Jan 07 '20 00:01 seanpmorgan

Looking more closely is this necessary? I didn't think adding it would hurt / hoped to expand bench-marking, but seems it may be more of a pain

seanpmorgan avatar Jan 07 '20 00:01 seanpmorgan

Seems like time.time() may be causing the problem timeit.default_timer() probably will fix the problem

chazuttu avatar Jan 12 '21 14:01 chazuttu

There Is already an upstream issue at https://github.com/tensorflow/tensorflow/issues/35884

bhack avatar Jan 13 '21 14:01 bhack