addons icon indicating copy to clipboard operation
addons copied to clipboard

exclude_from_weight_decay in RectifiedAdam()

Open markub3327 opened this issue 3 years ago • 4 comments

Describe the feature and the current behavior/state.

Can RectifiedAdam have same parameter exclude_from_weight_decay as AdamW? We must exclude some parameters of the model from weight decay.

Relevant information

  • Are you willing to contribute it (yes/no): yes If you wish to contribute, then read the requirements for new contributions in CONTRIBUTING.md
  • Are you willing to maintain it going forward? (yes/no): yes
  • Is there a relevant academic paper? (if so, where): no
  • Does the relavent academic paper exceed 50 citations? (yes/no): no
  • Is there already an implementation in another framework? (if so, where): yes
  • Was it part of tf.contrib? (if so, where): No

Which API type would this fall under (layer, metric, optimizer, etc.)

optimizer

Who will benefit with this feature?

Everyone

Any other info.

Thanks a lot.

markub3327 avatar Mar 07 '22 22:03 markub3327

Probably this component is orphan. Gently ping @szutenberg

@markub3327 Can you check with a ticket on https://github.com/keras-team/keras if they are interested if you port this in Keras with your exclude_from_weight_decay extension?

bhack avatar Mar 08 '22 18:03 bhack

@bhack The ticket is done.

markub3327 avatar Mar 08 '22 19:03 markub3327

Thank you as AdamW was just duplicated there 27 days ago probably you could add a comment there also for exclude_from_weight_decay for AdamW

bhack avatar Mar 08 '22 20:03 bhack

@bhack I have done it.

Please look here.

markub3327 avatar Mar 09 '22 06:03 markub3327

TensorFlow Addons is transitioning to a minimal maintenance and release mode. New features will not be added to this repository. For more information, please see our public messaging on this decision: TensorFlow Addons Wind Down

Please consider sending feature requests / contributions to other repositories in the TF community with a similar charters to TFA: Keras Keras-CV Keras-NLP

seanpmorgan avatar Mar 01 '23 03:03 seanpmorgan