tctl icon indicating copy to clipboard operation
tctl copied to clipboard

wish tctl show workflow information --pdt show datetime with local timezone

Open rmrf opened this issue 4 years ago • 11 comments

Is your feature request related to a problem? Please describe. tctl wf l command list workflow, but only display with UTC timezone

Describe the solution you'd like Local timezone will be greate

Describe alternatives you've considered How about use ENV to control whether use local timezone display, such as TEMPORAL_CLI_DISPLAY_TIMEZONE

Additional context n/a

rmrf avatar Jun 08 '21 09:06 rmrf

From my perspective, operationally it's safer to stick with utc. Could you talk about your use cases a little? Is this just for human consumption when occasionally looking at what ran or is running out of curiosity? Or would you want it for serious investigation, analysis or automation?

underrun avatar Jun 08 '21 13:06 underrun

Recently we are trying to migrate our tasks of several teams to Temporal, it is kind of totally new framework to all of us.

During the mgiration, we heavily depends on the tctl cmd line to troubleshooting:

  • When the activity/subworkflow start/end/terminate,
  • Such as tctl wf showid sloslihive_22ee1a63-6390-4ddc-b897-a89729361485 --pdt and so on.

The correct Timezone will make this kind work less painful.

rmrf avatar Jun 08 '21 13:06 rmrf

https://github.com/rmrf/temporal/tree/timezone

Currently we are using above modified tctl binary which suport env TEMPORAL_CLI_DISPLAY_TIMEZONE for nice time display.

rmrf avatar Jun 08 '21 14:06 rmrf

Added to this tctl UX proposal https://github.com/temporalio/proposals/pull/35

feedmeapples avatar Jun 16 '21 00:06 feedmeapples

if you happen to have any other feedback, please consider checking the rest of the proposals and leaving some comments. It's highly valuable and appreciated. The proposals focus a UX improvements for tctl

feedmeapples avatar Jun 16 '21 01:06 feedmeapples

if you happen to have any other feedback, please consider checking the rest of the proposals and leaving some comments. It's highly valuable and appreciated. The proposals focus a UX improvements for tctl

Thanks, glad to know this proposals repo.

rmrf avatar Jun 16 '21 04:06 rmrf

@feedmeapples looks like this would be addressed by the recent tctl work you are doing. Can you confirm?

samarabbas avatar Jul 04 '21 21:07 samarabbas

@rmrf could you elaborate on how having timezone flag makes it easier for your migration case. Do you want to know the exact time at specific timezone, or could something like relative time (ex. 2 hrs ago) make your migration simpler too? https://github.com/temporalio/proposals/pull/35/files#diff-fd43e76660a0644c8d5027ed26ef9dbb8086737f8145733070445413a18f4133R10

feedmeapples avatar Jul 07 '21 15:07 feedmeapples

@feedmeapples konwing the exact time at specific timezone is most valuable to us. We have two types of tasks migrating to Temperal

  • Ad-hoc tasks, which the owner define the exact task start time on their app platform, the platform will trigger http call to wf starter web server, then collect the result and display on the platform
  • Temporal cron type (such as run every minutes)

for the first one, exact time at specific timezone is meaning for to the owners, consider they are checking their app logs/metrics on kibana/grafana then cross compare with tctl's output, exact time at specific timezone is making this kind of work really easy.

recently we have setup the temporal web for the task owners, they are happy to have local timezone display on it (not every time display is local timezone, a lot of detail still in UTC, such as inside history tab, but for those one who don't like command line, it's a big help)

rmrf avatar Jul 07 '21 15:07 rmrf

If tempral wf/activity need to interactive with other existing service/app inside company, the time display locally as kibana/grafana/(other tools) will make them work better.

rmrf avatar Jul 07 '21 16:07 rmrf

@rmrf ok, i've updated the proposal to support specific timezones https://github.com/temporalio/proposals/pull/35#issuecomment-875922145

feedmeapples avatar Jul 07 '21 20:07 feedmeapples