sdk-typescript icon indicating copy to clipboard operation
sdk-typescript copied to clipboard

[DRAFT] feat(worker): Add support for HTTP CONNECT Proxy

Open mjameswh opened this issue 1 year ago • 2 comments

What was changed

  • Added support for HTTP CONNECT Proxy.
  • At this point, client side support is only possible by setting an environment variable; this will be improved in a future PR.

Why?

  • https://github.com/temporalio/features/issues/323

Example

Add the proxy property on Connection or NativeConnection options. For example:

  const connection = await NativeConnection.connect({
    address: 'localhost:7233',
    proxy: {
      type: 'http-connect',
      targetHost: '127.0.0.1:8888',
      basicAuth: {
        username: 'user',
        password: 'password',
      }
    },
  });

mjameswh avatar May 02 '24 21:05 mjameswh

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar May 02 '24 21:05 CLAassistant

As part of this, you may want some HTTP CONNECT feature tests. See https://github.com/temporalio/features/pull/448 for the Go and Java ones, and https://github.com/temporalio/features/compare/main...http-connect-proxy-python for the Python one (not yet merged because Python hasn't released the feature yet).

cretz avatar May 03 '24 12:05 cretz