sdk-typescript icon indicating copy to clipboard operation
sdk-typescript copied to clipboard

chore: CI Refactor

Open mjameswh opened this issue 2 years ago • 3 comments

What changed

  • Integration tests are now run on MacOS ARM and Linux ARM machines (tests for these platforms were not executed previously).
  • The bridge/rust library now run natively on MacOS ARM (it was previously cross-compiled).
  • The CI build and test workflows now use more recent version of various GitHub Actions commmands; in particular, we no longer use action/artifacts@v1 and @v2 commands, which will soon no longer be supported by GitHub.
  • The CI process now uses caching much more aggressively. For example, the process now avoids rebuilding native libraries if the rust code and dependencies haven't changed. This should considerably cut down the time it takes to get CI results (~10-15 minutes on the common case where a PR doesn't modify native code).
  • The CI process now gathers native artifacts for all platforms into a single package, paving the way to automate the release process.
  • It is now easy to run the SDK test suites with a specific version of the Temporal CLI and Time Skipping Test Server, by specifying the TESTS_CLI_VERSION and TESTS_TIME_SKIPPING_SERVER_VERSION environment variables.
  • The SDK test suites no longer attempts to run tests that require the Time Skipping Server on Linux ARM, as the test server is not available for that platform.

mjameswh avatar Dec 19 '22 20:12 mjameswh

Remaining flakes:

  • Connection ... rejected by server because of excess pings. Increasing ping interval ...
    • https://github.com/temporalio/sdk-typescript/actions/runs/4874659465/jobs/8696236782#step:13:9760
    • https://github.com/temporalio/sdk-typescript/actions/runs/4874659465/jobs/8784825762#step:13:10145
  • cb() never called
    • Node 14 - npm ci - https://github.com/temporalio/sdk-typescript/actions/runs/4874659465/jobs/8717971290#step:8:1288

mjameswh avatar May 04 '23 15:05 mjameswh

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jul 06 '23 17:07 CLAassistant

Can't yet add Node 22 to the build matrix due to https://github.com/nodejs/node/issues/52682.

mjameswh avatar May 01 '24 21:05 mjameswh