samples-server icon indicating copy to clipboard operation
samples-server copied to clipboard

FIX(promql-to-scrape, promql-to-dd-go): Proxy configuration from environment variables

Open ztalarick opened this issue 10 months ago • 2 comments

Changed client.go files to make API calls respect Proxy configuration from environment variables.

What was changed

Changed http client to initialize with environment variable proxies.

Why?

When using the sample server it wouldn't send API calls through our corporate proxy and API calls to temporal cloud would fail.

How was this tested:

Tested by monitoring logs and observed working /metrics endpoint.

ztalarick avatar Jan 13 '25 14:01 ztalarick

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Zach Talarick seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jan 13 '25 14:01 CLAassistant

@ztalarick Thanks for the PR. I can help you to merge once the CLA is signed.

taonic avatar Jan 14 '25 00:01 taonic