helm-charts icon indicating copy to clipboard operation
helm-charts copied to clipboard

Move additionalInitContainers to bottom in server-job.yaml

Open ragutsky opened this issue 10 months ago • 3 comments

What was changed

Moved admintools.additionalInitContainers to the bottom in server-job.

Why?

Since additional init containers run first there isn't a way to add additional steps to server job after schema setup/update (for instance, add search attributes).

Checklist

  1. Closes -

  2. How was this tested:

  • add value:
admintools:
  additionalInitContainers:
    - name: create-search-attributes
      image: temporalio/admin-tools:1.26.2
      imagePullPolicy: IfNotPresent
      command: ['/bin/sh','-c']
      args: ['temporal operator search-attribute create --namespace "my-namespace" --name="CustomId" --type="Keyword"']
  • run command helm template demo charts/temporal -s templates/server-job.yaml
  • check that added container is at the end
  1. Any docs updates needed?

No

ragutsky avatar Jan 13 '25 09:01 ragutsky

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jan 13 '25 09:01 CLAassistant

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jan 13 '25 09:01 CLAassistant

I appreciate the requirement here, but existing users rely on the additionalInitContainers behaving as-is in order to create cloud proxy sidecars etc to enable database connectivity. I think we should change to using preInitContainers and postInitContainers in values.yaml. additionalInitContainers would be removed from the example values.yaml file, but be supported as a legacy option and treated as postInitContainers which is more inline with the expectations of the name, albeit not what this template currently does. This would allow for both your use case and existing ones.

robholland avatar Feb 17 '25 13:02 robholland