helm-charts icon indicating copy to clipboard operation
helm-charts copied to clipboard

Published 20 hours ago • verified publisher icon temporalio

Add support for deployment labels and annotations

Open jonasrmichel opened this issue 1 year ago • 3 comments

What was changed

This PR adds support for configuring custom labels and annotations in the main metadata of all Deployment workloads:

  • server
  • server.frontend
  • server.history
  • server.matching
  • server.worker
  • admintools
  • web

Why?

These changes were added specifically to allow for custom server Deployment annotations so that a tool like stakater/Reloader may be used to auto-restart the server when persistence auth keys are rotated.

Checklist

  1. Closes

  2. How was this tested:

Local helm template rendering.

  1. Any docs updates needed?

jonasrmichel avatar Jul 24 '24 20:07 jonasrmichel

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jul 24 '24 20:07 CLAassistant

I'm going to wait for https://github.com/temporalio/helm-charts/pull/539 to be merged, please then adjust this to lean on the helper, and add a similar helper for annotations.

robholland avatar Aug 05 '24 10:08 robholland

#539 is now merged. Please can you re-work the PR based on that?

robholland avatar Aug 07 '24 08:08 robholland

Closing due to inactivity. Please re-open if you would like to re-base and continue.

robholland avatar Dec 04 '24 14:12 robholland