helm-charts
helm-charts copied to clipboard
add new options for TEMPORAL_CORS_ORIGINS and TEMPORAL_CSRF_COOKIE_INSECURE
What was changed
Adds options for TEMPORAL_CORS_ORIGINS and TEMPORAL_CSRF_COOKIE_INSECURE
Why?
So they can be configured more explicitly than through the additionalEnvs, lacking documentation on them so surfacing to dedicated options makes it easier to find the functionality. Also this usage is quite common for privately-networked deployments.
Checklist
-
Closes #401
-
How was this tested:
helm template
- Any docs updates needed?
No
@tsurdilo what's needed to merge this?
@tsurdilo this would be very helpful
How will this work with multiple cors origins? I am trying to decode how is UI config separating them and I don't really understand all the pieces involved
I see the env name is TEMPORAL_CORS_ORIGINS so I guess multiple is possible
but I also see this in the conf template in ui repo
allowOrigins:
# override framework's default that allows all origins "*"
- {{ default .Env.TEMPORAL_CORS_ORIGINS "http://localhost:8080" }}
this seems like the value is just put into single value list? Not sure
It was fixed here (already merged)
https://github.com/temporalio/ui/pull/1572
Should we close this MR?
A link to the web UI config docs is now included in the values.yaml. I don't think we should special case these.