helm-charts icon indicating copy to clipboard operation
helm-charts copied to clipboard

add new options for TEMPORAL_CORS_ORIGINS and TEMPORAL_CSRF_COOKIE_INSECURE

Open danthegoodman1 opened this issue 2 years ago • 6 comments

What was changed

Adds options for TEMPORAL_CORS_ORIGINS and TEMPORAL_CSRF_COOKIE_INSECURE

Why?

So they can be configured more explicitly than through the additionalEnvs, lacking documentation on them so surfacing to dedicated options makes it easier to find the functionality. Also this usage is quite common for privately-networked deployments.

Checklist

  1. Closes #401

  2. How was this tested:

helm template

  1. Any docs updates needed?

No

danthegoodman1 avatar Jul 03 '23 21:07 danthegoodman1

@tsurdilo what's needed to merge this?

danthegoodman1 avatar Jul 13 '23 12:07 danthegoodman1

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jul 15 '23 20:07 CLAassistant

@tsurdilo this would be very helpful

karelbilek avatar Aug 01 '23 10:08 karelbilek

How will this work with multiple cors origins? I am trying to decode how is UI config separating them and I don't really understand all the pieces involved

karelbilek avatar Aug 18 '23 09:08 karelbilek

I see the env name is TEMPORAL_CORS_ORIGINS so I guess multiple is possible

but I also see this in the conf template in ui repo

  allowOrigins:
    # override framework's default that allows all origins "*"
    - {{ default .Env.TEMPORAL_CORS_ORIGINS "http://localhost:8080" }}

this seems like the value is just put into single value list? Not sure

karelbilek avatar Aug 18 '23 09:08 karelbilek

It was fixed here (already merged)

https://github.com/temporalio/ui/pull/1572

karelbilek avatar Aug 28 '23 16:08 karelbilek

Should we close this MR?

jphilippelingrand avatar Jun 04 '24 14:06 jphilippelingrand

A link to the web UI config docs is now included in the values.yaml. I don't think we should special case these.

robholland avatar Jun 08 '24 16:06 robholland