tdesktop icon indicating copy to clipboard operation
tdesktop copied to clipboard

Windows build doc: add Graphviz to third party install list

Open vovodroid opened this issue 1 year ago • 8 comments
trafficstars

There is an error message problems opening map file libheif/apidoc/html/heif_8h__incl.map while running win.bat without Graphviz installed.

Add it to third party software list.

vovodroid avatar Aug 30 '24 13:08 vovodroid

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Aug 30 '24 13:08 CLAassistant

That's a wrong fix, graphviz shouldn't be needed.

ilya-fedin avatar Aug 31 '24 11:08 ilya-fedin

Probably, but after install and rerun win.bat error message gone.

vovodroid avatar Aug 31 '24 11:08 vovodroid

It's still a wrong fix. It should build without graphviz installed.

ilya-fedin avatar Aug 31 '24 12:08 ilya-fedin

There is also the same issue: Error running win.bat #27899, it was resolved by Graphviz install.

I agree that root cause could be something else.

vovodroid avatar Aug 31 '24 12:08 vovodroid

The right fix for #27899 is to remove doxygen so libheif doesn't look for graphviz

ilya-fedin avatar Aug 31 '24 12:08 ilya-fedin

Doxygen seems to be OFF in all occurrences

https://github.com/search?q=repo%3Atelegramdesktop%2Ftdesktop%20doxygen&type=code

vovodroid avatar Aug 31 '24 15:08 vovodroid

Doxygen seems to be OFF in all occurrences

I'm not sure what you want to say by that. The issue you linked says

CUSTOMBUILD : error : problems opening map file C:/TBuild/Libraries/win64/libheif/apidoc/html/heif_8h__incl.map for inc
lusion in the docs! [C:\TBuild\Libraries\win64\libheif\doc_doxygen.vcxproj]

ilya-fedin avatar Aug 31 '24 16:08 ilya-fedin