tdesktop icon indicating copy to clipboard operation
tdesktop copied to clipboard

replace Ctrl+F by F for full screen

Open GooseOb opened this issue 2 years ago • 12 comments

F as a hotkey is commonly used for toggling full screen and is used in Telegram Web too. Also, there are hotkeys in Telegram Web such as Shift+F, Alt+F, and Ctrl+F that make video go fullscreen.

Previously Ctrl+F hotkey used to make the search bar active, but as far as I can see it got fixed by now.

Closes #25866

GooseOb avatar Oct 05 '23 15:10 GooseOb

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Oct 05 '23 15:10 CLAassistant

Why don't you like Ctrl+Enter and Alt+Enter?

23rd avatar Oct 05 '23 21:10 23rd

I'm used to use F on youtube and found out about the shortcuts you mentioned while I was searching for shortcuts in the code

GooseOb avatar Oct 06 '23 07:10 GooseOb

I think changing hotkey that previously worked for years is a bad practice. I think I'll add an ability to customize hotkey to toggle full screen for videos.

23rd avatar Oct 12 '23 01:10 23rd

I think changing hotkey that previously worked for years is a bad practice. I think I'll add an ability to customize hotkey to toggle full screen for videos.

for all plz xd everyone wants to customize hotkeys :)

Aokromes avatar Oct 12 '23 07:10 Aokromes

But Ctrl+F still works, why is adding new hotkeys bad?

GooseOb avatar Oct 12 '23 23:10 GooseOb

But Ctrl+F still works

Hmm, yes, you're right. Alright then, anyway the final decision is up to Preston.

23rd avatar Oct 12 '23 23:10 23rd

Now you can customize this shortcut with a new media_viewer_video_fullscreen key in the shortcuts-custom.json file.

23rd avatar Oct 30 '23 20:10 23rd

I've changed config and now I cannot type f

GooseOb avatar Nov 02 '23 11:11 GooseOb

I've changed config and now I cannot type f

😯

23rd avatar Nov 02 '23 12:11 23rd

But Ctrl+F still works, why is adding new hotkeys bad?

Okay, there seems to be nothing critical to have an additional hotkey option...

23rd avatar Nov 05 '23 10:11 23rd