triggers
triggers copied to clipboard
Update CEL-GO to v0.20.1
Changes
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
- [ ] Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
- [ ] Has Tests included if any functionality added or changed
- [ ] Follows the commit message standard
- [ ] Meets the Tekton contributor standards (including functionality, content, code)
- [ ] Has a kind label. You can add one by adding a comment on this PR that contains
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep - [ ] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
- [ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release
Release Notes
NONE
Fixes: https://github.com/tektoncd/triggers/pull/1717
@khrm I think this needs a bit more than just updating.
The interceptor registers them here https://github.com/tektoncd/triggers/blob/main/pkg/interceptors/cel/cel.go#L106-L107
https://github.com/google/cel-go/tree/master/ext
I can see celext.Sets() and celext.Lists() and celext.Math() and celext.Protos() that could be added.
Sure. I would add. Thanks. It seems we miss this from earlier updates also.
@khrm I'm happy to review once you've made the changes :-)
I'd be inclined to add simple tests for each of the pieces of functionality to a) ensure they're registered correctly, and b) provide examples.
Also, they'll need to be added to the documentation https://tekton.dev/docs/triggers/cel_expressions/
@bigkevmcd @savitaashture I am raising another PR. Let's add this PR for version updates and cut the release.
@bigkevmcd @savitaashture I am raising another PR. Let's add this PR for version updates and cut the release.
Sure @khrm can you create an issue to track the same
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: savitaashture
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
So this PR got closed because I rebase and push. There was no difference.
@khrm Do you want me to do this work?
Sure. You can take this up. I was focussing on results first.