triggers icon indicating copy to clipboard operation
triggers copied to clipboard

Published 20 hours ago • verified publisher icon tektoncd

Knative undefined: injection.Dynamic

Open mike-sirs opened this issue 2 years ago • 7 comments

Knative dropped dynamic wrapped client generation

closed issue https://github.com/tektoncd/triggers/issues/1628

@khrm the issues still persist, the PR you've mentioned removed Dynamic from eventlistenersink/main.go while the problem is with
https://github.com/tektoncd/triggers/blob/cc1b7b73f165e9480f0cd92ac0b0f36e0f0be3e0/pkg/client/injection/client/client.go#L51C2-L51C64

/go/pkg/mod/github.com/tektoncd/[email protected]/pkg/client/injection/client/client.go:51:12: undefined: injection.Dynamic

go.mod:
	github.com/tektoncd/pipeline v0.50.1
	github.com/tektoncd/triggers v0.25.0
        knative.dev/pkg v0.0.0-20230718152110-aef227e72ead

could someone look at this, please?

https://github.com/knative/pkg/issues/2739

mike-sirs avatar Sep 11 '23 15:09 mike-sirs

Sure, I would remove this.

khrm avatar Sep 11 '23 18:09 khrm

/assign @khrm

khrm avatar Sep 11 '23 18:09 khrm

@mike-sirs Can you pick this up?

khrm avatar Jan 24 '24 16:01 khrm

/help-wanted

khrm avatar Jan 24 '24 16:01 khrm

/assign @mike-sirs

mike-sirs avatar Jan 27 '24 06:01 mike-sirs

@khrm https://github.com/tektoncd/triggers/pull/1687

mike-sirs avatar Feb 03 '24 20:02 mike-sirs

@mike-sirs This is done now. Should be part of the next release.

khrm avatar Mar 28 '24 16:03 khrm

I closed this as the issue should be resolved by now.

khrm avatar May 10 '24 12:05 khrm