triggers
triggers copied to clipboard
`githubOwners` and `addChangedFiles` do not work together when the `eventType` is `issue_comment`
Expected Behavior
Taskrun/pipelinerun should get created when a comment /ok-to-test is commented
Actual Behavior
Taskrun/pipelinerun not getting created when a comment /ok-to-test is commented
Steps to Reproduce the Problem
- Create a repository
- Create an event listener with github interceptor with params
githubOwners,addChangedFiles, andeventType(pull_request,issue_comment) - Create a PR from a different account which is not listed in OWNERS file
- Comment
/ok-to-teston the pull request
Additional Info
-
Kubernetes version:
Output of
kubectl version:Client Version: v1.25.7 Kustomize Version: v4.5.7 Server Version: v1.24.11+af0420d -
Tekton Pipeline version:
Output of
tkn versionorkubectl get pods -n tekton-pipelines -l app=tekton-pipelines-controller -o=jsonpath='{.items[0].metadata.labels.version}'Client version: 0.30.0 Pipeline version: v0.44.0 Triggers version: v0.23.0 Operator version: v0.65.1
/assign @kcloutie
@savitaashture: GitHub didn't allow me to assign the following users: kcloutie.
Note that only tektoncd members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide
In response to this:
/assign @kcloutie
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.
/lifecycle stale
Send feedback to tektoncd/plumbing.
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.
/lifecycle rotten
Send feedback to tektoncd/plumbing.
Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.
/close
Send feedback to tektoncd/plumbing.
@tekton-robot: Closing this issue.
In response to this:
Rotten issues close after 30d of inactivity. Reopen the issue with
/reopenwith a justification. Mark the issue as fresh with/remove-lifecycle rottenwith a justification. If this issue should be exempted, mark the issue as frozen with/lifecycle frozenwith a justification./close
Send feedback to tektoncd/plumbing.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
/remove-lifecycle rotten
We need to fix this in future.
/reopen
@khrm: Reopened this issue.
In response to this:
/reopen
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.