triggers icon indicating copy to clipboard operation
triggers copied to clipboard

Published 20 hours ago • verified publisher icon tektoncd

Add Namespaced Scope Interceptor

Open khrm opened this issue 3 years ago • 14 comments

Added Namespaced Scope Interceptor. A namespaced admin can create and manage its interceptor without requiring elevated permissions. Fixes #1364

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

  • [ ] Includes tests (if functionality changed/added)
  • [ ] Includes docs (if user facing)
  • [ ] Commit messages follow commit message best practices
  • [ ] Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

khrm avatar Oct 12 '22 07:10 khrm

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please ask for approval from khrm after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot avatar Oct 12 '22 07:10 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/triggers/v1alpha1/interceptor_defaults.go Do not exist N/A
pkg/apis/triggers/v1alpha1/interceptor_validation.go Do not exist 100.0%
pkg/apis/triggers/v1alpha1/ns_interceptor_types.go Do not exist 100.0%
pkg/reconciler/interceptor/controller.go Do not exist 0.0%
pkg/reconciler/interceptor/interceptor.go Do not exist 90.9%

tekton-robot avatar Oct 12 '22 07:10 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/triggers/v1alpha1/interceptor_defaults.go Do not exist N/A
pkg/apis/triggers/v1alpha1/interceptor_validation.go Do not exist 100.0%
pkg/apis/triggers/v1alpha1/ns_interceptor_types.go Do not exist 100.0%
pkg/reconciler/interceptor/controller.go Do not exist 0.0%
pkg/reconciler/interceptor/interceptor.go Do not exist 90.9%
pkg/sink/sink.go 73.1% 61.4% -11.7

tekton-robot avatar Oct 12 '22 10:10 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/adapter/adapter.go 28.8% 23.5% -5.3
pkg/apis/triggers/v1alpha1/interceptor_defaults.go Do not exist N/A
pkg/apis/triggers/v1alpha1/interceptor_validation.go Do not exist 100.0%
pkg/apis/triggers/v1alpha1/ns_interceptor_types.go Do not exist 100.0%
pkg/reconciler/interceptor/controller.go Do not exist 0.0%
pkg/reconciler/interceptor/interceptor.go Do not exist 90.9%
pkg/sink/sink.go 73.1% 61.4% -11.7

tekton-robot avatar Oct 12 '22 11:10 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/adapter/adapter.go 28.8% 23.5% -5.3
pkg/apis/triggers/v1alpha1/interceptor_defaults.go Do not exist N/A
pkg/apis/triggers/v1alpha1/interceptor_validation.go Do not exist 100.0%
pkg/apis/triggers/v1alpha1/ns_interceptor_types.go Do not exist 100.0%
pkg/reconciler/interceptor/controller.go Do not exist 0.0%
pkg/reconciler/interceptor/interceptor.go Do not exist 90.9%
pkg/sink/sink.go 73.1% 61.4% -11.7

tekton-robot avatar Oct 12 '22 18:10 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/adapter/adapter.go 28.8% 23.5% -5.3
pkg/apis/triggers/v1alpha1/interceptor_defaults.go Do not exist 0.0%
pkg/apis/triggers/v1alpha1/interceptor_validation.go Do not exist 100.0%
pkg/apis/triggers/v1alpha1/ns_interceptor_types.go Do not exist 100.0%
pkg/reconciler/interceptor/controller.go Do not exist 0.0%
pkg/reconciler/interceptor/interceptor.go Do not exist 90.9%
pkg/sink/sink.go 73.1% 61.4% -11.7

tekton-robot avatar Oct 12 '22 18:10 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/adapter/adapter.go 28.8% 23.5% -5.3
pkg/apis/triggers/v1alpha1/interceptor_defaults.go Do not exist 0.0%
pkg/apis/triggers/v1alpha1/interceptor_validation.go Do not exist 100.0%
pkg/apis/triggers/v1alpha1/ns_interceptor_types.go Do not exist 100.0%
pkg/reconciler/interceptor/controller.go Do not exist 0.0%
pkg/reconciler/interceptor/interceptor.go Do not exist 90.9%
pkg/sink/sink.go 73.1% 69.7% -3.4

tekton-robot avatar Oct 12 '22 18:10 tekton-robot

/hold cancel

khrm avatar Oct 13 '22 05:10 khrm

The following is the coverage report on the affected files. Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/adapter/adapter.go 28.8% 23.5% -5.3
pkg/apis/triggers/v1alpha1/interceptor_defaults.go Do not exist 0.0%
pkg/apis/triggers/v1alpha1/interceptor_validation.go Do not exist 100.0%
pkg/apis/triggers/v1alpha1/ns_interceptor_types.go Do not exist 100.0%
pkg/reconciler/interceptor/controller.go Do not exist 0.0%
pkg/reconciler/interceptor/interceptor.go Do not exist 90.9%
pkg/sink/sink.go 73.1% 72.0% -1.1
test/controller.go 71.8% 70.5% -1.3

tekton-robot avatar Oct 13 '22 05:10 tekton-robot

/test pull-tekton-triggers-integration-tests

khrm avatar Oct 13 '22 06:10 khrm

The following is the coverage report on the affected files. Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/adapter/adapter.go 28.8% 23.5% -5.3
pkg/apis/triggers/v1alpha1/interceptor_defaults.go Do not exist 0.0%
pkg/apis/triggers/v1alpha1/interceptor_validation.go Do not exist 100.0%
pkg/apis/triggers/v1alpha1/ns_interceptor_types.go Do not exist 100.0%
pkg/reconciler/interceptor/controller.go Do not exist 0.0%
pkg/reconciler/interceptor/interceptor.go Do not exist 90.9%
pkg/sink/sink.go 73.1% 72.0% -1.1
test/controller.go 71.8% 70.5% -1.3

tekton-robot avatar Oct 13 '22 09:10 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/adapter/adapter.go 28.8% 23.5% -5.3
pkg/apis/triggers/v1alpha1/interceptor_defaults.go Do not exist 0.0%
pkg/apis/triggers/v1alpha1/interceptor_validation.go Do not exist 100.0%
pkg/apis/triggers/v1alpha1/ns_interceptor_types.go Do not exist 100.0%
pkg/reconciler/interceptor/controller.go Do not exist 0.0%
pkg/reconciler/interceptor/interceptor.go Do not exist 90.9%
pkg/sink/sink.go 73.1% 72.0% -1.1
test/controller.go 71.8% 70.5% -1.3

tekton-robot avatar Oct 13 '22 14:10 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/adapter/adapter.go 28.8% 23.5% -5.3
pkg/apis/triggers/v1alpha1/interceptor_defaults.go Do not exist 0.0%
pkg/apis/triggers/v1alpha1/interceptor_validation.go Do not exist 100.0%
pkg/apis/triggers/v1alpha1/ns_interceptor_types.go Do not exist 100.0%
pkg/reconciler/interceptor/controller.go Do not exist 0.0%
pkg/reconciler/interceptor/interceptor.go Do not exist 90.9%
pkg/sink/sink.go 73.1% 72.0% -1.1
test/controller.go 71.8% 70.5% -1.3

tekton-robot avatar Oct 13 '22 15:10 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/adapter/adapter.go 28.8% 23.5% -5.3
pkg/apis/triggers/v1alpha1/interceptor_defaults.go Do not exist 0.0%
pkg/apis/triggers/v1alpha1/interceptor_validation.go Do not exist 100.0%
pkg/apis/triggers/v1alpha1/ns_interceptor_types.go Do not exist 100.0%
pkg/reconciler/interceptor/controller.go Do not exist 0.0%
pkg/reconciler/interceptor/interceptor.go Do not exist 90.9%
pkg/sink/sink.go 73.1% 72.0% -1.1
test/controller.go 71.8% 70.5% -1.3

tekton-robot avatar Oct 14 '22 12:10 tekton-robot

@savitaashture @dibyom Please review this.

Also, I am facing this issue inside EL:

resource=interceptors not supported

Are we registering new CRD somewhere else also apart from register.go and webhook?

khrm avatar Oct 17 '22 10:10 khrm

The following is the coverage report on the affected files. Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/adapter/adapter.go 28.8% 23.5% -5.3
pkg/apis/triggers/v1alpha1/interceptor_defaults.go Do not exist 0.0%
pkg/apis/triggers/v1alpha1/interceptor_validation.go Do not exist 100.0%
pkg/apis/triggers/v1alpha1/ns_interceptor_types.go Do not exist 100.0%
pkg/reconciler/interceptor/controller.go Do not exist 0.0%
pkg/reconciler/interceptor/interceptor.go Do not exist 90.9%
pkg/sink/sink.go 73.1% 72.0% -1.1
test/controller.go 71.8% 70.5% -1.3

tekton-robot avatar Oct 17 '22 10:10 tekton-robot

/test tekton-triggers-unit-tests

khrm avatar Oct 17 '22 10:10 khrm

@khrm Can you add some examples to show how it looks?

savitaashture avatar Oct 17 '22 14:10 savitaashture

@savitaashture @dibyom Please review this.

Also, I am facing this issue inside EL:

resource=interceptors not supported

Are we registering new CRD somewhere else also apart from register.go and webhook?

I :thinking: we are not registering any other place apart from that

savitaashture avatar Oct 17 '22 14:10 savitaashture

@savitaashture I would add examples and documentation later.

khrm avatar Oct 17 '22 15:10 khrm

The following is the coverage report on the affected files. Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/adapter/adapter.go 28.8% 23.5% -5.3
pkg/apis/triggers/v1alpha1/interceptor_defaults.go Do not exist 0.0%
pkg/apis/triggers/v1alpha1/interceptor_validation.go Do not exist 100.0%
pkg/apis/triggers/v1alpha1/ns_interceptor_types.go Do not exist 100.0%
pkg/reconciler/interceptor/controller.go Do not exist 0.0%
pkg/reconciler/interceptor/interceptor.go Do not exist 90.9%
pkg/sink/sink.go 73.1% 72.0% -1.1
test/controller.go 71.8% 70.5% -1.3

tekton-robot avatar Oct 18 '22 18:10 tekton-robot

@khrm: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-tekton-triggers-integration-tests b6b783b3c0e9b8a268c9c153eb8e64edc51abe70 link true /test pull-tekton-triggers-integration-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

tekton-robot avatar Oct 18 '22 19:10 tekton-robot

resource=interceptors not supported

@khrm do you have the line from the EL that is returning that? Or is that during start up?

dibyom avatar Oct 19 '22 18:10 dibyom

The following is the coverage report on the affected files. Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/adapter/adapter.go 28.8% 23.5% -5.3
pkg/apis/triggers/v1alpha1/interceptor_defaults.go Do not exist 0.0%
pkg/apis/triggers/v1alpha1/interceptor_types.go 66.7% 90.9% 24.2
pkg/apis/triggers/v1alpha1/interceptor_validation.go Do not exist 100.0%
pkg/reconciler/interceptor/controller.go Do not exist 0.0%
pkg/reconciler/interceptor/interceptor.go Do not exist 90.9%
test/controller.go 71.8% 70.5% -1.3

tekton-robot avatar Nov 09 '22 20:11 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/adapter/adapter.go 28.8% 23.5% -5.3
pkg/apis/triggers/v1alpha1/interceptor_defaults.go Do not exist 0.0%
pkg/apis/triggers/v1alpha1/interceptor_types.go 66.7% 90.9% 24.2
pkg/apis/triggers/v1alpha1/interceptor_validation.go Do not exist 100.0%
pkg/reconciler/interceptor/controller.go Do not exist 0.0%
pkg/reconciler/interceptor/interceptor.go Do not exist 90.9%
pkg/sink/sink.go 73.0% 72.0% -1.0
test/controller.go 71.8% 70.5% -1.3

tekton-robot avatar Nov 09 '22 20:11 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/adapter/adapter.go 28.8% 23.5% -5.3
pkg/apis/triggers/v1alpha1/interceptor_defaults.go Do not exist 0.0%
pkg/apis/triggers/v1alpha1/interceptor_types.go 66.7% 90.9% 24.2
pkg/apis/triggers/v1alpha1/interceptor_validation.go Do not exist 100.0%
pkg/reconciler/interceptor/controller.go Do not exist 0.0%
pkg/reconciler/interceptor/interceptor.go Do not exist 90.9%
pkg/sink/sink.go 73.0% 72.0% -1.0
test/controller.go 71.8% 70.5% -1.3

tekton-robot avatar Nov 09 '22 21:11 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/adapter/adapter.go 28.8% 23.5% -5.3
pkg/apis/triggers/v1alpha1/interceptor_defaults.go Do not exist 0.0%
pkg/apis/triggers/v1alpha1/interceptor_types.go 66.7% 90.9% 24.2
pkg/apis/triggers/v1alpha1/interceptor_validation.go Do not exist 100.0%
pkg/reconciler/interceptor/controller.go Do not exist 0.0%
pkg/reconciler/interceptor/interceptor.go Do not exist 90.9%
pkg/sink/sink.go 73.0% 72.0% -1.0
test/controller.go 71.8% 70.5% -1.3

tekton-robot avatar Nov 09 '22 23:11 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/adapter/adapter.go 28.8% 23.5% -5.3
pkg/apis/triggers/v1alpha1/interceptor_defaults.go Do not exist 0.0%
pkg/apis/triggers/v1alpha1/interceptor_types.go 66.7% 90.9% 24.2
pkg/apis/triggers/v1alpha1/interceptor_validation.go Do not exist 100.0%
pkg/reconciler/interceptor/controller.go Do not exist 0.0%
pkg/reconciler/interceptor/interceptor.go Do not exist 90.9%
pkg/sink/sink.go 73.0% 72.0% -1.0
test/controller.go 71.8% 70.5% -1.3

tekton-robot avatar Nov 10 '22 00:11 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/adapter/adapter.go 28.8% 23.5% -5.3
pkg/apis/triggers/v1alpha1/interceptor_defaults.go Do not exist 0.0%
pkg/apis/triggers/v1alpha1/interceptor_types.go 66.7% 90.9% 24.2
pkg/apis/triggers/v1alpha1/interceptor_validation.go Do not exist 100.0%
pkg/reconciler/interceptor/controller.go Do not exist 0.0%
pkg/reconciler/interceptor/interceptor.go Do not exist 90.9%
pkg/sink/sink.go 73.0% 72.0% -1.0
test/controller.go 71.8% 70.5% -1.3

tekton-robot avatar Nov 10 '22 01:11 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/adapter/adapter.go 28.8% 23.5% -5.3
pkg/apis/triggers/v1alpha1/interceptor_defaults.go Do not exist 0.0%
pkg/apis/triggers/v1alpha1/interceptor_types.go 66.7% 90.9% 24.2
pkg/apis/triggers/v1alpha1/interceptor_validation.go Do not exist 100.0%
pkg/reconciler/interceptor/controller.go Do not exist 0.0%
pkg/reconciler/interceptor/interceptor.go Do not exist 90.9%
pkg/sink/sink.go 73.0% 72.0% -1.0
test/controller.go 71.8% 70.5% -1.3

tekton-robot avatar Nov 10 '22 01:11 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/adapter/adapter.go 28.8% 23.5% -5.3
pkg/apis/triggers/v1alpha1/interceptor_defaults.go Do not exist 0.0%
pkg/apis/triggers/v1alpha1/interceptor_types.go 66.7% 90.9% 24.2
pkg/apis/triggers/v1alpha1/interceptor_validation.go Do not exist 100.0%
pkg/reconciler/interceptor/controller.go Do not exist 0.0%
pkg/reconciler/interceptor/interceptor.go Do not exist 90.9%
pkg/sink/sink.go 73.0% 72.0% -1.0
test/controller.go 71.8% 70.5% -1.3

tekton-robot avatar Nov 10 '22 01:11 tekton-robot

If a clusterinterceptor and interceptor have the same name, which one is used?

I didn't get this. Which place are you talking about? We specify InterceptorKind in the ref.

khrm avatar Nov 11 '22 05:11 khrm