pipeline icon indicating copy to clipboard operation
pipeline copied to clipboard

[FIX] Remove the apt warning

Open leshikus opened this issue 8 months ago β€’ 5 comments

Changes

The apt manpage recommends against using it in scripts and issues a warning. This patch fixes the warning.

It also adds an option to debug ci worlflow via workflow_dispatch, and removes yamllint exception by properly formatting the on clause.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • [x] Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • [x] Has Tests included if any functionality added or changed
  • [x] pre-commit Passed
  • [x] Follows the commit message standard
  • [x] Meets the Tekton contributor standards (including functionality, content, code)
  • [x] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • [x] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • [x] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

leshikus avatar Mar 06 '25 17:03 leshikus

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: leshikus / name: Alexei Fedotov (852523563bbdfcd6834a6905a23fe92784a5be86, c284adb9d40afb038d384b2ed67052829f6a6983, 084554f7b9394b7365e1041d2da1c5eb88eda874)
  • :white_check_mark: login: waveywaves / name: Vibhav Bobade (59647df25ee70d2c6d63605e9470275933527cab)

/kind cleanup

leshikus avatar Mar 06 '25 18:03 leshikus

@pritidesai how can I make progress with this PR?

leshikus avatar Mar 11 '25 07:03 leshikus

@vdemeester @afrittoli , can we progress with this patch? I was thinking about spending some time working on this project and resolving more serious issues in future.

leshikus avatar Mar 29 '25 09:03 leshikus

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot avatar Jun 11 '25 13:06 tekton-robot

I wonder how can this PR get this LGTM label

leshikus avatar Jul 12 '25 12:07 leshikus

@leshikus can you take care of my last comment, and I'll LGTM πŸ‘ΌπŸΌ πŸ˜‰

vdemeester avatar Jul 16 '25 09:07 vdemeester

@leshikus I have updated the PR with the required change on your behalf hope that is ok, this is so that we can fast-forward this PR :)

cc @vdemeester

waveywaves avatar Aug 14 '25 10:08 waveywaves

@waveywaves thanks! sorry for missing the previous request

leshikus avatar Aug 14 '25 11:08 leshikus

/lgtm ing based on Vincent's last comment πŸš€

waveywaves avatar Aug 14 '25 14:08 waveywaves