tektoncd
feat: improve step.Script variables references validation message
Changes
feat: #8265
Scripts are often long and hard to read. When checking variable references, put non-existent variables before the message to make it easier to read.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
- [ ] Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
- [x] Has Tests included if any functionality added or changed
- [x] pre-commit Passed
- [x] Follows the commit message standard
- [x] Meets the Tekton contributor standards (including functionality, content, code)
- [x] Has a kind label. You can add one by adding a comment on this PR that contains
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep - [x] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
- [ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release
Release Notes
improve step.Script variables references validation message
@chengjoey: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:
/test pull-tekton-pipeline-alpha-integration-tests/test pull-tekton-pipeline-beta-integration-tests/test pull-tekton-pipeline-build-tests/test pull-tekton-pipeline-integration-tests/test pull-tekton-pipeline-unit-tests
The following commands are available to trigger optional jobs:
/test pull-tekton-pipeline-go-coverage
Use /test all to run all jobs.
In response to this:
/test check-pr-has-kind-label
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/substitution/substitution.go | 87.0% | 86.0% | -0.9 |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/substitution/substitution.go | 87.0% | 86.0% | -0.9 |
@chengjoey: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:
/test pull-tekton-pipeline-alpha-integration-tests/test pull-tekton-pipeline-beta-integration-tests/test pull-tekton-pipeline-build-tests/test pull-tekton-pipeline-integration-tests/test pull-tekton-pipeline-unit-tests
The following commands are available to trigger optional jobs:
/test pull-tekton-pipeline-go-coverage
Use /test all to run all jobs.
In response to this:
/test check-pr-has-kind-label
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/substitution/substitution.go | 87.0% | 87.6% | 0.6 |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/substitution/substitution.go | 87.0% | 87.6% | 0.6 |
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: vdemeester
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [vdemeester]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@jkhelil: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:
/test pull-tekton-pipeline-alpha-integration-tests/test pull-tekton-pipeline-beta-integration-tests/test pull-tekton-pipeline-build-tests/test pull-tekton-pipeline-integration-tests/test pull-tekton-pipeline-unit-tests
The following commands are available to trigger optional jobs:
/test pull-tekton-pipeline-go-coverage
Use /test all to run all jobs.
In response to this:
/test pull-tekton-pipeline-go-coverage-df
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/substitution/substitution.go | 87.0% | 87.6% | 0.6 |
Well done!
Finally, I don't have to check one by one who left it undefined.
I really hope we can merge this PR soon.
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/substitution/substitution.go | 87.0% | 87.6% | 0.6 |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/substitution/substitution.go | 87.0% | 87.6% | 0.6 |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/substitution/substitution.go | 87.0% | 87.6% | 0.6 |
@l-qing Would you like to join the organization as a member? https://github.com/tektoncd/community/tree/main/org
@l-qing Would you like to join the organization as a member? https://github.com/tektoncd/community/tree/main/org
Thank you for bringing this opportunity to my attention.
I had never considered the possibility of joining this organization before, but I'm genuinely excited about the prospect of becoming a member.
Upon reviewing the membership requirements, I noticed I still have some areas to work on. While I'm proud to have contributed with over 30 merged PRs, I realize I haven't participated in reviewing others' contributions. I mistakenly assumed that PR reviews were limited to existing members - I now see how wrong I was about that! 😄
I'm committed to meeting all the requirements and look forward to submitting my membership application in 2025.
While I'm proud to have contributed with over 30 merged PRs
you've done a great job, and I very much welcome you to become a member. you can submit a PR to community, I think this can be done through
While I'm proud to have contributed with over 30 merged PRs
you've done a great job, and I very much welcome you to become a member. you can submit a PR to community, I think this can be done through
Thank you for your encouragement.
I still intend to wait until all the requirements are met before initiating the PR request, to avoid wasting others' review time.
I will prioritize this matter as the most important thing in the next three months.