pipeline
pipeline copied to clipboard
tektoncd
Fix Artifact type to a pointer
Prior to this, the Artifacts in TaskRunStatusFields was not set to a pointer of the underlying struct. As a result, it was incompatible with tkn. Here we fix that issue by updating it to a pointer.
Fixes https://github.com/tektoncd/pipeline/issues/8225
Changes
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
- [ ] Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
- [x] Has Tests included if any functionality added or changed
- [x] pre-commit Passed
- [x] Follows the commit message standard
- [x] Meets the Tekton contributor standards (including functionality, content, code)
- [x] Has a kind label. You can add one by adding a comment on this PR that contains
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep - [x] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
- [ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release
Release Notes
Fix Artifact type to a pointer.
@chitrangpatel: once the present PR merges, I will cherry-pick it on top of release-v0.62.x in a new PR and assign it to you.
In response to this:
/cherry-pick release-v0.62.x
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/apis/pipeline/v1/artifact_types.go | 95.5% | 95.7% | 0.2 |
| pkg/reconciler/pipelinerun/resources/apply.go | 97.3% | 97.3% | 0.0 |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/apis/pipeline/v1/artifact_types.go | 95.5% | 95.7% | 0.2 |
| pkg/reconciler/pipelinerun/resources/apply.go | 97.3% | 97.3% | 0.0 |
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: vdemeester
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [vdemeester]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/apis/pipeline/v1/artifact_types.go | 95.5% | 95.7% | 0.2 |
| pkg/reconciler/pipelinerun/resources/apply.go | 97.3% | 97.3% | 0.0 |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/apis/pipeline/v1/artifact_types.go | 95.5% | 95.7% | 0.2 |
| pkg/reconciler/pipelinerun/resources/apply.go | 97.3% | 97.3% | 0.0 |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/apis/pipeline/v1/artifact_types.go | 95.5% | 95.7% | 0.2 |
| pkg/reconciler/pipelinerun/resources/apply.go | 97.3% | 97.3% | 0.0 |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/apis/pipeline/v1/artifact_types.go | 95.5% | 95.7% | 0.2 |
| pkg/reconciler/pipelinerun/resources/apply.go | 97.3% | 97.3% | 0.0 |
@chitrangpatel: #8226 failed to apply on top of branch "release-v0.62.x":
Applying: Fix Artifact type to a pointer
Using index info to reconstruct a base tree...
M pkg/apis/pipeline/v1/openapi_generated.go
M pkg/apis/pipeline/v1/swagger.json
M pkg/apis/pipeline/v1/taskrun_types.go
M pkg/apis/pipeline/v1/zz_generated.deepcopy.go
M pkg/pod/status.go
M pkg/pod/status_test.go
M pkg/reconciler/pipelinerun/resources/apply_test.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/reconciler/pipelinerun/resources/apply_test.go
Auto-merging pkg/pod/status_test.go
CONFLICT (content): Merge conflict in pkg/pod/status_test.go
Auto-merging pkg/pod/status.go
Auto-merging pkg/apis/pipeline/v1/zz_generated.deepcopy.go
Auto-merging pkg/apis/pipeline/v1/taskrun_types.go
Auto-merging pkg/apis/pipeline/v1/swagger.json
Auto-merging pkg/apis/pipeline/v1/openapi_generated.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Fix Artifact type to a pointer
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to this:
/cherry-pick release-v0.62.x
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
