pipeline
pipeline copied to clipboard
tektoncd
feat: Add support for when within matrix.include
Changes
add support for when within matrix.include feat #8152
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
- [x] Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
- [x] Has Tests included if any functionality added or changed
- [x] pre-commit Passed
- [x] Follows the commit message standard
- [x] Meets the Tekton contributor standards (including functionality, content, code)
- [x] Has a kind label. You can add one by adding a comment on this PR that contains
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep - [x] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
- [ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release
Release Notes
matrix.include support when expressions
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/apis/pipeline/v1/matrix_types.go | 100.0% | 98.6% | -1.4 |
| pkg/apis/pipeline/v1/pipeline_validation.go | 99.3% | 99.0% | -0.2 |
| pkg/apis/pipeline/v1beta1/matrix_types.go | 100.0% | 98.6% | -1.4 |
| pkg/apis/pipeline/v1beta1/pipeline_conversion.go | 95.4% | 91.2% | -4.1 |
| pkg/reconciler/pipelinerun/resources/apply.go | 97.3% | 96.8% | -0.6 |
| pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go | 96.7% | 96.7% | 0.0 |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/apis/pipeline/v1/matrix_types.go | 100.0% | 98.6% | -1.4 |
| pkg/apis/pipeline/v1/pipeline_validation.go | 99.3% | 99.0% | -0.2 |
| pkg/apis/pipeline/v1beta1/matrix_types.go | 100.0% | 98.6% | -1.4 |
| pkg/apis/pipeline/v1beta1/pipeline_conversion.go | 95.4% | 91.2% | -4.1 |
| pkg/reconciler/pipelinerun/resources/apply.go | 97.3% | 96.8% | -0.6 |
| pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go | 96.7% | 96.7% | 0.0 |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/apis/pipeline/v1/matrix_types.go | 100.0% | 98.6% | -1.4 |
| pkg/apis/pipeline/v1/pipeline_validation.go | 99.3% | 99.0% | -0.2 |
| pkg/apis/pipeline/v1beta1/matrix_types.go | 100.0% | 98.6% | -1.4 |
| pkg/apis/pipeline/v1beta1/pipeline_conversion.go | 95.4% | 91.2% | -4.1 |
| pkg/apis/pipeline/v1beta1/pipeline_validation.go | 99.0% | 98.8% | -0.2 |
| pkg/reconciler/pipelinerun/resources/apply.go | 97.3% | 96.8% | -0.6 |
| pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go | 96.7% | 96.7% | 0.0 |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/apis/pipeline/v1/matrix_types.go | 100.0% | 98.6% | -1.4 |
| pkg/apis/pipeline/v1/pipeline_validation.go | 99.3% | 99.0% | -0.2 |
| pkg/apis/pipeline/v1beta1/matrix_types.go | 100.0% | 98.6% | -1.4 |
| pkg/apis/pipeline/v1beta1/pipeline_conversion.go | 95.4% | 91.2% | -4.1 |
| pkg/apis/pipeline/v1beta1/pipeline_validation.go | 99.0% | 98.8% | -0.2 |
| pkg/reconciler/pipelinerun/resources/apply.go | 97.3% | 96.8% | -0.6 |
| pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go | 96.7% | 96.7% | 0.0 |
@chengjoey: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-tekton-pipeline-build-tests | 627c308fac45d3fa56fa463055778c59314c8e69 | link | true | /test pull-tekton-pipeline-build-tests |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: vdemeester
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [vdemeester]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@chengjoey: PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.