Add feature flag `set-security-context-read-only-root-filesystem` to set readOnlyRootFilesystem for containers

[kristofferchr]

Solves: https://github.com/tektoncd/pipeline/issues/8183

Depends on: https://github.com/tektoncd/pipeline/pull/8182

Changes

Add a flag to enable setting the readOnlyRootFilesystem field in the securityContext for containers used in pipelinerun, taskrun and affinity assistants

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• [x] Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
• [x] Has Tests included if any functionality added or changed
• [x] pre-commit Passed
• [x] Follows the commit message standard
• [x] Meets the Tekton contributor standards (including functionality, content, code)
• [x] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
• [x] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
• [x] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

New feature flag `set-security-context-read-only-root-filesystem` in ConfigMap `feature-flags`. The new feature sets readOnlyRootFilesystem in securityContext for taskrun, pipelinerun and affinity assistant containers.

[tekton-robot]

Hi @kristofferchr. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kristofferchr]

/kind feature

[kristofferchr]

/test pull-tekton-pipeline-go-coverage-df

[tekton-robot]

@kristofferchr: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-tekton-pipeline-go-coverage-df

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tekton-robot]

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/config/feature_flags.go	95.1%	94.4%	-0.7
pkg/pod/SecurityContext.go	Do not exist	85.7%
pkg/pod/pod.go	93.9%	94.2%	0.3
pkg/pod/script.go	99.0%	99.0%	-0.0
pkg/pod/workingdir_init.go	95.0%	94.1%	-0.9
pkg/reconciler/pipelinerun/affinity_assistant.go	96.9%	97.0%	0.1

[tekton-robot]

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/config/feature_flags.go	95.1%	94.4%	-0.7
pkg/pod/pod.go	93.9%	94.2%	0.3
pkg/pod/script.go	99.0%	99.0%	-0.0
pkg/pod/security_context_config.go	Do not exist	85.7%
pkg/pod/workingdir_init.go	95.0%	94.1%	-0.9
pkg/reconciler/pipelinerun/affinity_assistant.go	96.9%	97.0%	0.1

[tekton-robot]

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/config/feature_flags.go	95.1%	94.4%	-0.7
pkg/pod/pod.go	93.0%	93.3%	0.3
pkg/pod/script.go	99.1%	99.1%	-0.0
pkg/pod/security_context_config.go	Do not exist	85.7%
pkg/pod/workingdir_init.go	95.0%	94.1%	-0.9

[kristofferchr]

/retest

[tekton-robot]

@kristofferchr: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tekton-robot]

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/config/feature_flags.go	95.1%	94.4%	-0.7
pkg/pod/pod.go	93.0%	93.3%	0.3
pkg/pod/script.go	99.1%	99.1%	-0.0
pkg/pod/security_context_config.go	Do not exist	85.7%
pkg/pod/workingdir_init.go	95.0%	94.1%	-0.9

[tekton-robot]

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/config/feature_flags.go	95.1%	94.4%	-0.7
pkg/pod/pod.go	93.0%	93.3%	0.3
pkg/pod/script.go	99.1%	99.1%	-0.0
pkg/pod/security_context_config.go	Do not exist	85.7%
pkg/pod/workingdir_init.go	95.0%	94.1%	-0.9

[tekton-robot]

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/config/feature_flags.go	95.1%	94.4%	-0.7
pkg/pod/pod.go	93.0%	93.3%	0.3
pkg/pod/script.go	99.1%	99.1%	-0.0
pkg/pod/security_context_config.go	Do not exist	85.7%
pkg/pod/workingdir_init.go	95.0%	94.1%	-0.9

[tekton-robot]

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/config/feature_flags.go	95.1%	94.4%	-0.7
pkg/pod/pod.go	93.0%	93.3%	0.3
pkg/pod/script.go	99.1%	99.1%	-0.0
pkg/pod/security_context_config.go	Do not exist	100.0%
pkg/pod/workingdir_init.go	95.0%	94.1%	-0.9

[tekton-robot]

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/config/feature_flags.go	95.1%	95.2%	0.1
pkg/pod/pod.go	93.0%	93.3%	0.3
pkg/pod/script.go	99.1%	99.1%	-0.0
pkg/pod/security_context_config.go	Do not exist	100.0%
pkg/pod/workingdir_init.go	95.0%	94.1%	-0.9

[kristofferchr]

Is this ok-to-test @vdemeester ?

[vdemeester]

@kristofferchr yes, it is ok, and test rans.. But you will probably need to rebase or commit/amend/push to force the new workflow to run (we moved some of them 🙏🏼 )

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [vdemeester]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[afrittoli]

/ok-to-test