pipeline icon indicating copy to clipboard operation
pipeline copied to clipboard

Fix error message when a PipelineRun param is missing

Open samagana opened this issue 1 year ago • 4 comments

Changes

Closes #8062 Fix the error message that is thrown when a param is missing from being passed in a PipelineRun.

  1. In case the pipelinerun is using a ref, the referenced pipeline entity's name would be used
  2. Else, the pipeline entity name would be same as the pipelinerun's name. This is consistent with the existing error strings in similar workflows (eg: when types do not match, invalid spec etc)

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • [ ] Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • [x] Has Tests included if any functionality added or changed
  • [x] pre-commit Passed
  • [x] Follows the commit message standard
  • [x] Meets the Tekton contributor standards (including functionality, content, code)
  • [x] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • [ ] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • [x] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Improved error string when a param is missing from a PipelineRun

samagana avatar Jun 22 '24 19:06 samagana

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: samagana / name: Samarth Maganahalli (69c5dc0b42201fbf03848dfb1b55e05787851eea, a1f998e5090fd091187f900432f3ab7a68ae72d9, d56d361031144a9ab543c073fb95e4cb74efdcbc, 2ca940207c5370c1f0f51a5f5738f6701c722001)

Hi @samagana. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot avatar Jun 22 '24 19:06 tekton-robot

/kind bug

samagana avatar Jun 22 '24 19:06 samagana

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot avatar Jul 03 '24 07:07 tekton-robot

/lgtm

chitrangpatel avatar Jul 04 '24 19:07 chitrangpatel