tektoncd
misc: promote stepAction to beta
Promote StepAction to Beta.
This PR promotes StepActions to beta. It adds the necessary types and configs and conversion webhooks. It also updates the internal storage type to use v1beta1 for StepActions.
Changes
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
- [x] Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
- [x] Has Tests included if any functionality added or changed
- [x] pre-commit Passed
- [x] Follows the commit message standard
- [x] Meets the Tekton contributor standards (including functionality, content, code)
- [x] Has a kind label. You can add one by adding a comment on this PR that contains
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep - [x] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
- [ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release
Release Notes
promote StepActions to beta
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/apis/pipeline/v1/stepaction_conversion.go | Do not exist | 66.7% | |
| pkg/apis/pipeline/v1/stepaction_defaults.go | Do not exist | 100.0% | |
| pkg/apis/pipeline/v1/stepaction_types.go | Do not exist | 0.0% | |
| pkg/apis/pipeline/v1/stepaction_validation.go | Do not exist | 98.9% | |
| pkg/apis/pipeline/v1beta1/result_validation.go | 100.0% | 80.8% | -19.2 |
| pkg/apis/pipeline/v1beta1/stepaction_conversion.go | Do not exist | 92.3% | |
| pkg/apis/pipeline/v1beta1/stepaction_defaults.go | Do not exist | 100.0% | |
| pkg/apis/pipeline/v1beta1/stepaction_types.go | Do not exist | 0.0% | |
| pkg/apis/pipeline/v1beta1/stepaction_validation.go | Do not exist | 98.9% | |
| pkg/apis/pipeline/v1beta1/task_validation.go | 98.6% | 98.9% | 0.3 |
| pkg/reconciler/taskrun/resources/taskref.go | 94.2% | 88.4% | -5.8 |
| test/parse/yaml.go | 50.6% | 13.1% | -37.5 |
| test/parse/yaml.go | Do not exist | 10.7% | |
| test/parse/yaml.go | Do not exist | 50.6% |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/apis/pipeline/v1/stepaction_conversion.go | Do not exist | 66.7% | |
| pkg/apis/pipeline/v1/stepaction_defaults.go | Do not exist | 100.0% | |
| pkg/apis/pipeline/v1/stepaction_types.go | Do not exist | 0.0% | |
| pkg/apis/pipeline/v1/stepaction_validation.go | Do not exist | 98.9% | |
| pkg/apis/pipeline/v1beta1/result_validation.go | 100.0% | 80.8% | -19.2 |
| pkg/apis/pipeline/v1beta1/stepaction_conversion.go | Do not exist | 92.3% | |
| pkg/apis/pipeline/v1beta1/stepaction_defaults.go | Do not exist | 100.0% | |
| pkg/apis/pipeline/v1beta1/stepaction_types.go | Do not exist | 0.0% | |
| pkg/apis/pipeline/v1beta1/stepaction_validation.go | Do not exist | 98.9% | |
| pkg/apis/pipeline/v1beta1/task_validation.go | 98.6% | 98.9% | 0.3 |
| pkg/reconciler/taskrun/resources/taskref.go | 94.2% | 88.4% | -5.8 |
| test/parse/yaml.go | 50.6% | 33.7% | -16.9 |
| test/parse/yaml.go | Do not exist | 17.5% | |
| test/parse/yaml.go | Do not exist | 8.3% |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/apis/pipeline/v1/stepaction_conversion.go | Do not exist | 66.7% | |
| pkg/apis/pipeline/v1/stepaction_defaults.go | Do not exist | 100.0% | |
| pkg/apis/pipeline/v1/stepaction_types.go | Do not exist | 0.0% | |
| pkg/apis/pipeline/v1/stepaction_validation.go | Do not exist | 98.9% | |
| pkg/apis/pipeline/v1beta1/result_validation.go | 100.0% | 80.8% | -19.2 |
| pkg/apis/pipeline/v1beta1/stepaction_conversion.go | Do not exist | 92.3% | |
| pkg/apis/pipeline/v1beta1/stepaction_defaults.go | Do not exist | 100.0% | |
| pkg/apis/pipeline/v1beta1/stepaction_types.go | Do not exist | 0.0% | |
| pkg/apis/pipeline/v1beta1/stepaction_validation.go | Do not exist | 98.9% | |
| pkg/apis/pipeline/v1beta1/task_validation.go | 98.6% | 98.9% | 0.3 |
| pkg/reconciler/apiserver/apiserver.go | 97.2% | 97.6% | 0.3 |
| pkg/reconciler/taskrun/resources/taskref.go | 94.2% | 88.4% | -5.8 |
| test/parse/yaml.go | 50.6% | 19.6% | -31.0 |
| test/parse/yaml.go | Do not exist | 15.1% | |
| test/parse/yaml.go | Do not exist | 38.7% |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/apis/pipeline/v1/stepaction_conversion.go | Do not exist | 66.7% | |
| pkg/apis/pipeline/v1/stepaction_defaults.go | Do not exist | 100.0% | |
| pkg/apis/pipeline/v1/stepaction_types.go | Do not exist | 0.0% | |
| pkg/apis/pipeline/v1/stepaction_validation.go | Do not exist | 98.9% | |
| pkg/apis/pipeline/v1beta1/result_validation.go | 100.0% | 80.8% | -19.2 |
| pkg/apis/pipeline/v1beta1/stepaction_conversion.go | Do not exist | 92.3% | |
| pkg/apis/pipeline/v1beta1/stepaction_defaults.go | Do not exist | 100.0% | |
| pkg/apis/pipeline/v1beta1/stepaction_types.go | Do not exist | 0.0% | |
| pkg/apis/pipeline/v1beta1/stepaction_validation.go | Do not exist | 98.9% | |
| pkg/apis/pipeline/v1beta1/task_validation.go | 98.6% | 98.9% | 0.3 |
| pkg/reconciler/apiserver/apiserver.go | 97.2% | 97.6% | 0.3 |
| pkg/reconciler/taskrun/resources/taskref.go | 94.2% | 88.4% | -5.8 |
| test/parse/yaml.go | 50.6% | 33.7% | -16.9 |
| test/parse/yaml.go | Do not exist | 17.5% | |
| test/parse/yaml.go | Do not exist | 8.3% |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/apis/pipeline/v1alpha1/stepaction_conversion.go | 0.0% | 88.9% | 88.9 |
| pkg/apis/pipeline/v1beta1/stepaction_conversion.go | Do not exist | 0.0% | |
| pkg/apis/pipeline/v1beta1/stepaction_defaults.go | Do not exist | 100.0% | |
| pkg/apis/pipeline/v1beta1/stepaction_types.go | Do not exist | 0.0% | |
| pkg/apis/pipeline/v1beta1/stepaction_validation.go | Do not exist | 98.9% | |
| pkg/reconciler/apiserver/apiserver.go | 97.2% | 97.6% | 0.3 |
| pkg/reconciler/taskrun/resources/taskref.go | 94.2% | 88.3% | -5.9 |
| test/parse/yaml.go | 50.6% | 17.5% | -33.2 |
| test/parse/yaml.go | Do not exist | 13.1% | |
| test/parse/yaml.go | Do not exist | 38.7% |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/apis/pipeline/v1alpha1/stepaction_conversion.go | 0.0% | 88.9% | 88.9 |
| pkg/apis/pipeline/v1beta1/stepaction_conversion.go | Do not exist | 0.0% | |
| pkg/apis/pipeline/v1beta1/stepaction_defaults.go | Do not exist | 100.0% | |
| pkg/apis/pipeline/v1beta1/stepaction_types.go | Do not exist | 0.0% | |
| pkg/apis/pipeline/v1beta1/stepaction_validation.go | Do not exist | 98.9% | |
| pkg/reconciler/apiserver/apiserver.go | 97.2% | 97.6% | 0.3 |
| pkg/reconciler/taskrun/resources/taskref.go | 94.2% | 88.3% | -5.9 |
| test/parse/yaml.go | 50.6% | 33.7% | -16.9 |
| test/parse/yaml.go | Do not exist | 15.5% | |
| test/parse/yaml.go | Do not exist | 8.3% |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/apis/pipeline/v1alpha1/stepaction_conversion.go | 0.0% | 88.9% | 88.9 |
| pkg/apis/pipeline/v1beta1/stepaction_conversion.go | Do not exist | 0.0% | |
| pkg/apis/pipeline/v1beta1/stepaction_defaults.go | Do not exist | 100.0% | |
| pkg/apis/pipeline/v1beta1/stepaction_types.go | Do not exist | 0.0% | |
| pkg/apis/pipeline/v1beta1/stepaction_validation.go | Do not exist | 98.9% | |
| pkg/reconciler/apiserver/apiserver.go | 97.2% | 97.6% | 0.3 |
| pkg/reconciler/taskrun/resources/taskref.go | 94.2% | 88.3% | -5.9 |
| test/parse/yaml.go | 50.6% | 13.1% | -37.5 |
| test/parse/yaml.go | Do not exist | 8.3% | |
| test/parse/yaml.go | Do not exist | 47.6% |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/apis/pipeline/v1alpha1/stepaction_conversion.go | 0.0% | 88.9% | 88.9 |
| pkg/apis/pipeline/v1beta1/stepaction_conversion.go | Do not exist | 0.0% | |
| pkg/apis/pipeline/v1beta1/stepaction_defaults.go | Do not exist | 100.0% | |
| pkg/apis/pipeline/v1beta1/stepaction_types.go | Do not exist | 0.0% | |
| pkg/apis/pipeline/v1beta1/stepaction_validation.go | Do not exist | 98.9% | |
| pkg/reconciler/apiserver/apiserver.go | 97.2% | 97.6% | 0.3 |
| pkg/reconciler/taskrun/resources/taskref.go | 94.2% | 88.3% | -5.9 |
| test/parse/yaml.go | 50.6% | 33.7% | -16.9 |
| test/parse/yaml.go | Do not exist | 15.5% | |
| test/parse/yaml.go | Do not exist | 8.3% |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/apis/pipeline/v1alpha1/stepaction_conversion.go | 0.0% | 88.9% | 88.9 |
| pkg/apis/pipeline/v1beta1/stepaction_conversion.go | Do not exist | 0.0% | |
| pkg/apis/pipeline/v1beta1/stepaction_defaults.go | Do not exist | 100.0% | |
| pkg/apis/pipeline/v1beta1/stepaction_types.go | Do not exist | 0.0% | |
| pkg/apis/pipeline/v1beta1/stepaction_validation.go | Do not exist | 98.9% | |
| pkg/reconciler/apiserver/apiserver.go | 97.2% | 97.6% | 0.3 |
| pkg/reconciler/taskrun/resources/taskref.go | 94.2% | 88.3% | -5.9 |
| test/parse/yaml.go | 50.6% | 33.7% | -16.9 |
| test/parse/yaml.go | Do not exist | 15.5% | |
| test/parse/yaml.go | Do not exist | 8.3% |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/apis/pipeline/v1alpha1/stepaction_conversion.go | 0.0% | 88.9% | 88.9 |
| pkg/apis/pipeline/v1beta1/stepaction_conversion.go | Do not exist | 0.0% | |
| pkg/apis/pipeline/v1beta1/stepaction_defaults.go | Do not exist | 100.0% | |
| pkg/apis/pipeline/v1beta1/stepaction_types.go | Do not exist | 0.0% | |
| pkg/apis/pipeline/v1beta1/stepaction_validation.go | Do not exist | 98.9% | |
| pkg/reconciler/apiserver/apiserver.go | 97.2% | 97.6% | 0.3 |
| pkg/reconciler/taskrun/resources/taskref.go | 94.2% | 88.3% | -5.9 |
| test/parse/yaml.go | 50.6% | 17.5% | -33.2 |
| test/parse/yaml.go | Do not exist | 13.1% | |
| test/parse/yaml.go | Do not exist | 38.7% |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/apis/pipeline/v1alpha1/stepaction_conversion.go | 0.0% | 88.9% | 88.9 |
| pkg/apis/pipeline/v1beta1/stepaction_conversion.go | Do not exist | 0.0% | |
| pkg/apis/pipeline/v1beta1/stepaction_defaults.go | Do not exist | 100.0% | |
| pkg/apis/pipeline/v1beta1/stepaction_types.go | Do not exist | 0.0% | |
| pkg/apis/pipeline/v1beta1/stepaction_validation.go | Do not exist | 98.9% | |
| pkg/reconciler/apiserver/apiserver.go | 97.2% | 97.6% | 0.3 |
| pkg/reconciler/taskrun/resources/taskref.go | 94.2% | 88.3% | -5.9 |
| test/parse/yaml.go | 50.6% | 69.0% | 18.4 |
| test/parse/yaml.go | Do not exist | 19.0% | |
| test/parse/yaml.go | Do not exist | 14.9% | |
| test/parse/yaml.go | Do not exist | 8.3% |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/apis/pipeline/v1alpha1/stepaction_conversion.go | 0.0% | 88.9% | 88.9 |
| pkg/apis/pipeline/v1beta1/stepaction_conversion.go | Do not exist | 0.0% | |
| pkg/apis/pipeline/v1beta1/stepaction_defaults.go | Do not exist | 100.0% | |
| pkg/apis/pipeline/v1beta1/stepaction_types.go | Do not exist | 0.0% | |
| pkg/apis/pipeline/v1beta1/stepaction_validation.go | Do not exist | 98.9% | |
| pkg/reconciler/apiserver/apiserver.go | 97.2% | 97.6% | 0.3 |
| pkg/reconciler/taskrun/resources/taskref.go | 94.2% | 93.0% | -1.2 |
| test/parse/yaml.go | 50.6% | 17.5% | -33.2 |
| test/parse/yaml.go | Do not exist | 13.1% | |
| test/parse/yaml.go | Do not exist | 38.7% |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/apis/pipeline/v1alpha1/stepaction_conversion.go | 0.0% | 88.9% | 88.9 |
| pkg/apis/pipeline/v1beta1/stepaction_conversion.go | Do not exist | 0.0% | |
| pkg/apis/pipeline/v1beta1/stepaction_defaults.go | Do not exist | 100.0% | |
| pkg/apis/pipeline/v1beta1/stepaction_types.go | Do not exist | 0.0% | |
| pkg/apis/pipeline/v1beta1/stepaction_validation.go | Do not exist | 98.9% | |
| pkg/reconciler/apiserver/apiserver.go | 97.2% | 97.6% | 0.3 |
| pkg/reconciler/taskrun/resources/taskref.go | 94.2% | 93.0% | -1.2 |
| test/parse/yaml.go | 50.6% | 33.7% | -16.9 |
| test/parse/yaml.go | Do not exist | 15.5% | |
| test/parse/yaml.go | Do not exist | 8.3% |
@tektoncd/core-collaborators PTAL. Looking for a review from a non-Googler. Thanks!
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/apis/pipeline/v1alpha1/stepaction_conversion.go | 0.0% | 88.9% | 88.9 |
| pkg/apis/pipeline/v1beta1/stepaction_conversion.go | Do not exist | 0.0% | |
| pkg/apis/pipeline/v1beta1/stepaction_defaults.go | Do not exist | 100.0% | |
| pkg/apis/pipeline/v1beta1/stepaction_types.go | Do not exist | 0.0% | |
| pkg/apis/pipeline/v1beta1/stepaction_validation.go | Do not exist | 98.9% | |
| pkg/reconciler/apiserver/apiserver.go | 97.2% | 97.6% | 0.3 |
| pkg/reconciler/taskrun/resources/taskref.go | 94.2% | 93.0% | -1.2 |
| test/parse/yaml.go | 8.9% | 19.0% | 10.2 |
| test/parse/yaml.go | Do not exist | 25.7% | |
| test/parse/yaml.go | Do not exist | 8.3% |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/apis/pipeline/v1alpha1/stepaction_conversion.go | 0.0% | 88.9% | 88.9 |
| pkg/apis/pipeline/v1beta1/stepaction_conversion.go | Do not exist | 0.0% | |
| pkg/apis/pipeline/v1beta1/stepaction_defaults.go | Do not exist | 100.0% | |
| pkg/apis/pipeline/v1beta1/stepaction_types.go | Do not exist | 0.0% | |
| pkg/apis/pipeline/v1beta1/stepaction_validation.go | Do not exist | 98.9% | |
| pkg/reconciler/apiserver/apiserver.go | 97.2% | 97.6% | 0.3 |
| pkg/reconciler/taskrun/resources/taskref.go | 94.2% | 93.0% | -1.2 |
| test/parse/yaml.go | 8.9% | 33.7% | 24.9 |
| test/parse/yaml.go | Do not exist | 15.5% | |
| test/parse/yaml.go | Do not exist | 8.3% |
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: chitrangpatel, JeromeJu
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [JeromeJu,chitrangpatel]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/apis/pipeline/v1alpha1/stepaction_conversion.go | 0.0% | 94.4% | 94.4 |
| pkg/apis/pipeline/v1beta1/stepaction_conversion.go | Do not exist | 0.0% | |
| pkg/apis/pipeline/v1beta1/stepaction_defaults.go | Do not exist | 100.0% | |
| pkg/apis/pipeline/v1beta1/stepaction_types.go | Do not exist | 0.0% | |
| pkg/apis/pipeline/v1beta1/stepaction_validation.go | Do not exist | 98.9% | |
| pkg/reconciler/apiserver/apiserver.go | 97.2% | 97.6% | 0.3 |
| pkg/reconciler/taskrun/resources/taskref.go | 94.2% | 93.0% | -1.2 |
| test/parse/yaml.go | 8.9% | 19.0% | 10.2 |
| test/parse/yaml.go | Do not exist | 15.5% | |
| test/parse/yaml.go | Do not exist | 30.2% |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/apis/pipeline/v1alpha1/stepaction_conversion.go | 0.0% | 94.4% | 94.4 |
| pkg/apis/pipeline/v1beta1/stepaction_conversion.go | Do not exist | 0.0% | |
| pkg/apis/pipeline/v1beta1/stepaction_defaults.go | Do not exist | 100.0% | |
| pkg/apis/pipeline/v1beta1/stepaction_types.go | Do not exist | 0.0% | |
| pkg/apis/pipeline/v1beta1/stepaction_validation.go | Do not exist | 98.9% | |
| pkg/reconciler/apiserver/apiserver.go | 97.2% | 97.6% | 0.3 |
| pkg/reconciler/taskrun/resources/taskref.go | 94.2% | 93.0% | -1.2 |
| test/parse/yaml.go | 8.9% | 33.7% | 24.9 |
| test/parse/yaml.go | Do not exist | 15.5% | |
| test/parse/yaml.go | Do not exist | 8.3% |
Merging this now since everyone has been on board with promoting stepactions to beta. This just adds the same structs into v1beta1, updates the storage type and adds conversion logic between v1alpha1 and v1beta1 as per the TEP. Its not doing anything that may be controversial. It has been open for three weeks already so I'm merging this in using maintainer discretion and because of reasons mentioned above.
Happy to resolve any friction/comments in a follow-up PR if needed.
/lgtm