pipeline icon indicating copy to clipboard operation
pipeline copied to clipboard

TEP0152 - Complete V1 conformance test suite

Open JeromeJu opened this issue 1 year ago • 4 comments

Changes

This PR consists of the V1 REQUIRED fields for v1 conformance.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • [x] Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • [x] Has Tests included if any functionality added or changed
  • [x] pre-commit Passed
  • [x] Follows the commit message standard
  • [x] Meets the Tekton contributor standards (including functionality, content, code)
  • [x] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • [ ] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • [ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

JeromeJu avatar Apr 25 '24 16:04 JeromeJu

For clarity and easy to read, I would suggest moving the yamls to individual files under testdata folder or something. And then add something that reads those yamls and runs the test. That would make it easy to parse and read (atleast to know which cases we have covered) and add more tests in the future.

chitrangpatel avatar May 02 '24 17:05 chitrangpatel

/approve

chitrangpatel avatar May 06 '24 15:05 chitrangpatel

For clarity and easy to read, I would suggest moving the yamls to individual files under testdata folder or something. And then add something that reads those yamls and runs the test. That would make it easy to parse and read (atleast to know which cases we have covered) and add more tests in the future.

Adding some outputs for the offline discussion we had - this is not done as fof the case of this PR mainly because we are having customized inputs for the YAML (which, potentially, could cause invalid YAML error with '%s' inputs in the files if we separate them out in different files).

cc @tektoncd/core-maintainers @tektoncd/core-collaborators PTAL 🙏

JeromeJu avatar May 09 '24 16:05 JeromeJu

cc @tektoncd/core-maintainers can i have a lgtm?

JeromeJu avatar May 16 '24 20:05 JeromeJu

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chitrangpatel, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [chitrangpatel,vdemeester]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot avatar May 29 '24 08:05 tekton-robot