pipeline icon indicating copy to clipboard operation
pipeline copied to clipboard

Add Deadline Exceeded to transient error in resolver

Open khrm opened this issue 1 year ago • 8 comments

Sometime webhook or git server might take time, so we need to add deadline exceeded to transient error.

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • [ ] Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • [x] Has Tests included if any functionality added or changed
  • [x] pre-commit Passed
  • [ ] Follows the commit message standard
  • [ ] Meets the Tekton contributor standards (including functionality, content, code)
  • [ ] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • [ ] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • [ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

khrm avatar Apr 18 '24 08:04 khrm

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign abayer after the PR has been reviewed. You can assign the PR to them by writing /assign @abayer in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot avatar Apr 18 '24 08:04 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/taskrun/resources/taskref.go 94.0% 93.2% -0.8

tekton-robot avatar Apr 18 '24 09:04 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/taskrun/resources/taskref.go 94.0% 93.2% -0.8

tekton-robot avatar Apr 18 '24 09:04 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/taskrun/resources/taskref.go 94.0% 93.2% -0.8

tekton-robot avatar Apr 18 '24 09:04 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/taskrun/resources/taskref.go 94.0% 93.2% -0.8

tekton-robot avatar Apr 18 '24 09:04 tekton-robot

/hold Need to test in live scenario.

khrm avatar Apr 18 '24 10:04 khrm

We probably need this only for specific error like pipelines-webhook issue.

khrm avatar Apr 18 '24 11:04 khrm

fyi @khrm I've opened https://github.com/tektoncd/pipeline/issues/7909 and at the moment have updated my PR https://github.com/tektoncd/pipeline/pull/7894 to say it fixes the new issue, where my PR checks for these transient errors on both the core controller and remote resolver side.

I know we only touched on this just briefly in one of our team meetings today. But either here or in slack let me know which PR you want to focus our efforts on. And of course, if you disagree with my checks in both controllers, let's discuss.

Thanks.

gabemontero avatar Apr 24 '24 19:04 gabemontero

Merged. We can close this. /close

khrm avatar May 16 '24 14:05 khrm

@khrm: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot avatar May 16 '24 14:05 tekton-robot