pipeline icon indicating copy to clipboard operation
pipeline copied to clipboard
verified publisher icon tektoncd

TEP-0097 breakpoint before steps for taskrun

Open chengjoey opened this issue 2 years ago • 27 comments

Changes

breakpoint before steps for taskrun TEP-0097 #5691

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • [x] Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • [x] Has Tests included if any functionality added or changed
  • [x] Follows the commit message standard
  • [x] Meets the Tekton contributor standards (including functionality, content, code)
  • [x] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • [x] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • [ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

breakpoint before a step

chengjoey avatar Nov 18 '23 05:11 chengjoey

/kind feature

chengjoey avatar Nov 18 '23 05:11 chengjoey

/assign @chitrangpatel @lbernick

chengjoey avatar Nov 18 '23 05:11 chengjoey

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/entrypoint/main.go 11.6% 12.7% 1.1
pkg/apis/pipeline/v1/taskrun_types.go 81.4% 82.8% 1.5
pkg/apis/pipeline/v1/taskrun_validation.go 96.9% 97.1% 0.1
pkg/apis/pipeline/v1beta1/taskrun_conversion.go 93.3% 93.5% 0.2
pkg/apis/pipeline/v1beta1/taskrun_types.go 82.3% 83.6% 1.3
pkg/apis/pipeline/v1beta1/taskrun_validation.go 97.0% 97.1% 0.1
pkg/entrypoint/entrypointer.go 87.6% 87.7% 0.1
pkg/pod/entrypoint.go 93.4% 93.5% 0.1
pkg/pod/script.go 99.0% 99.1% 0.1

tekton-robot avatar Nov 18 '23 05:11 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/entrypoint/main.go 11.6% 12.7% 1.1
pkg/apis/pipeline/v1/taskrun_types.go 81.4% 82.8% 1.5
pkg/apis/pipeline/v1/taskrun_validation.go 96.9% 97.1% 0.1
pkg/apis/pipeline/v1beta1/taskrun_conversion.go 93.3% 93.5% 0.2
pkg/apis/pipeline/v1beta1/taskrun_types.go 82.3% 83.6% 1.3
pkg/apis/pipeline/v1beta1/taskrun_validation.go 97.0% 97.1% 0.1
pkg/entrypoint/entrypointer.go 87.6% 87.7% 0.1
pkg/pod/entrypoint.go 93.4% 93.5% 0.1
pkg/pod/script.go 99.0% 99.1% 0.1

tekton-robot avatar Nov 18 '23 05:11 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/entrypoint/main.go 11.6% 12.7% 1.1
pkg/apis/pipeline/v1/taskrun_types.go 81.4% 82.8% 1.5
pkg/apis/pipeline/v1/taskrun_validation.go 96.9% 97.1% 0.1
pkg/apis/pipeline/v1beta1/taskrun_conversion.go 93.3% 93.5% 0.2
pkg/apis/pipeline/v1beta1/taskrun_types.go 82.3% 83.6% 1.3
pkg/apis/pipeline/v1beta1/taskrun_validation.go 97.0% 97.1% 0.1
pkg/entrypoint/entrypointer.go 87.6% 87.7% 0.1
pkg/pod/entrypoint.go 93.4% 93.5% 0.1
pkg/pod/script.go 99.0% 99.1% 0.1

tekton-robot avatar Nov 18 '23 13:11 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/entrypoint/main.go 11.6% 12.7% 1.1
pkg/apis/pipeline/v1/taskrun_types.go 81.4% 82.8% 1.5
pkg/apis/pipeline/v1/taskrun_validation.go 96.9% 97.1% 0.1
pkg/apis/pipeline/v1beta1/taskrun_conversion.go 93.3% 93.5% 0.2
pkg/apis/pipeline/v1beta1/taskrun_types.go 82.3% 83.6% 1.3
pkg/apis/pipeline/v1beta1/taskrun_validation.go 97.0% 97.1% 0.1
pkg/entrypoint/entrypointer.go 87.6% 87.7% 0.1
pkg/pod/entrypoint.go 93.4% 93.5% 0.1
pkg/pod/script.go 99.0% 99.1% 0.1

tekton-robot avatar Nov 18 '23 13:11 tekton-robot

/test pull-tekton-pipeline-build-tests

chengjoey avatar Nov 18 '23 15:11 chengjoey

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/entrypoint/main.go 11.6% 12.7% 1.1
pkg/apis/pipeline/v1/taskrun_types.go 81.4% 82.8% 1.5
pkg/apis/pipeline/v1/taskrun_validation.go 96.9% 97.1% 0.1
pkg/apis/pipeline/v1beta1/taskrun_conversion.go 93.3% 93.5% 0.2
pkg/apis/pipeline/v1beta1/taskrun_types.go 82.3% 83.6% 1.3
pkg/apis/pipeline/v1beta1/taskrun_validation.go 97.0% 97.1% 0.1
pkg/entrypoint/entrypointer.go 87.6% 87.7% 0.1
pkg/pod/entrypoint.go 93.4% 93.5% 0.1
pkg/pod/script.go 99.0% 99.1% 0.1

tekton-robot avatar Nov 20 '23 01:11 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/entrypoint/main.go 11.6% 12.7% 1.1
pkg/apis/pipeline/v1/taskrun_types.go 81.4% 82.8% 1.5
pkg/apis/pipeline/v1/taskrun_validation.go 96.9% 97.1% 0.1
pkg/apis/pipeline/v1beta1/taskrun_conversion.go 93.3% 93.5% 0.2
pkg/apis/pipeline/v1beta1/taskrun_types.go 82.3% 83.6% 1.3
pkg/apis/pipeline/v1beta1/taskrun_validation.go 97.0% 97.1% 0.1
pkg/entrypoint/entrypointer.go 87.6% 87.7% 0.1
pkg/pod/entrypoint.go 93.4% 93.5% 0.1
pkg/pod/script.go 99.0% 99.1% 0.1

tekton-robot avatar Nov 20 '23 01:11 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/entrypoint/main.go 11.6% 12.7% 1.1
pkg/apis/pipeline/v1/taskrun_types.go 81.4% 82.8% 1.5
pkg/apis/pipeline/v1/taskrun_validation.go 96.9% 97.1% 0.1
pkg/apis/pipeline/v1beta1/taskrun_conversion.go 93.3% 93.5% 0.2
pkg/apis/pipeline/v1beta1/taskrun_types.go 82.3% 83.6% 1.3
pkg/apis/pipeline/v1beta1/taskrun_validation.go 97.0% 97.1% 0.1
pkg/entrypoint/entrypointer.go 87.6% 87.7% 0.1
pkg/pod/entrypoint.go 93.4% 93.5% 0.1
pkg/pod/script.go 99.0% 99.1% 0.1

tekton-robot avatar Nov 20 '23 02:11 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/entrypoint/main.go 11.6% 12.7% 1.1
pkg/apis/pipeline/v1/taskrun_types.go 81.4% 82.8% 1.5
pkg/apis/pipeline/v1/taskrun_validation.go 96.9% 97.1% 0.1
pkg/apis/pipeline/v1beta1/taskrun_conversion.go 93.3% 93.5% 0.2
pkg/apis/pipeline/v1beta1/taskrun_types.go 82.3% 83.6% 1.3
pkg/apis/pipeline/v1beta1/taskrun_validation.go 97.0% 97.1% 0.1
pkg/entrypoint/entrypointer.go 87.6% 87.7% 0.1
pkg/pod/entrypoint.go 93.4% 93.5% 0.1
pkg/pod/script.go 99.0% 99.1% 0.1

tekton-robot avatar Nov 20 '23 02:11 tekton-robot

/approve

chitrangpatel avatar Dec 19 '23 14:12 chitrangpatel

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chitrangpatel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot avatar Dec 19 '23 14:12 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/entrypoint/main.go 11.6% 12.7% 1.1
pkg/apis/pipeline/v1/taskrun_types.go 81.4% 82.8% 1.5
pkg/apis/pipeline/v1/taskrun_validation.go 96.9% 97.0% 0.1
pkg/apis/pipeline/v1beta1/taskrun_conversion.go 91.8% 92.0% 0.2
pkg/apis/pipeline/v1beta1/taskrun_types.go 82.3% 83.6% 1.3
pkg/apis/pipeline/v1beta1/taskrun_validation.go 96.9% 97.1% 0.1
pkg/entrypoint/entrypointer.go 89.3% 89.2% -0.1

tekton-robot avatar Jan 25 '24 03:01 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/entrypoint/main.go 11.6% 12.7% 1.1
pkg/apis/pipeline/v1/taskrun_types.go 81.4% 82.8% 1.5
pkg/apis/pipeline/v1/taskrun_validation.go 96.9% 97.0% 0.1
pkg/apis/pipeline/v1beta1/taskrun_conversion.go 91.8% 92.0% 0.2
pkg/apis/pipeline/v1beta1/taskrun_types.go 82.3% 83.6% 1.3
pkg/apis/pipeline/v1beta1/taskrun_validation.go 96.9% 97.1% 0.1
pkg/entrypoint/entrypointer.go 89.3% 89.2% -0.1

tekton-robot avatar Jan 25 '24 03:01 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/entrypoint/main.go 11.6% 12.7% 1.1
pkg/apis/pipeline/v1/taskrun_types.go 81.4% 82.8% 1.5
pkg/apis/pipeline/v1/taskrun_validation.go 96.9% 97.0% 0.1
pkg/apis/pipeline/v1beta1/taskrun_conversion.go 91.8% 92.0% 0.2
pkg/apis/pipeline/v1beta1/taskrun_types.go 82.3% 83.6% 1.3
pkg/apis/pipeline/v1beta1/taskrun_validation.go 96.9% 97.1% 0.1
pkg/entrypoint/entrypointer.go 89.3% 89.2% -0.1
pkg/pod/entrypoint.go 94.1% 94.2% 0.1
pkg/pod/script.go 99.0% 99.1% 0.1

tekton-robot avatar Jan 26 '24 09:01 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/entrypoint/main.go 11.6% 12.7% 1.1
pkg/apis/pipeline/v1/taskrun_types.go 81.4% 82.8% 1.5
pkg/apis/pipeline/v1/taskrun_validation.go 96.9% 97.0% 0.1
pkg/apis/pipeline/v1beta1/taskrun_conversion.go 91.8% 92.0% 0.2
pkg/apis/pipeline/v1beta1/taskrun_types.go 82.3% 83.6% 1.3
pkg/apis/pipeline/v1beta1/taskrun_validation.go 96.9% 97.1% 0.1
pkg/entrypoint/entrypointer.go 89.3% 89.2% -0.1
pkg/pod/entrypoint.go 94.1% 94.2% 0.1
pkg/pod/script.go 99.0% 99.1% 0.1

tekton-robot avatar Jan 26 '24 09:01 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/entrypoint/main.go 11.6% 12.7% 1.1
pkg/apis/pipeline/v1/taskrun_types.go 81.4% 82.8% 1.5
pkg/apis/pipeline/v1/taskrun_validation.go 96.9% 97.0% 0.1
pkg/apis/pipeline/v1beta1/taskrun_conversion.go 91.9% 92.1% 0.2
pkg/apis/pipeline/v1beta1/taskrun_types.go 82.3% 83.6% 1.3
pkg/apis/pipeline/v1beta1/taskrun_validation.go 96.9% 97.1% 0.1
pkg/entrypoint/entrypointer.go 89.0% 88.9% -0.1
pkg/pod/entrypoint.go 94.1% 94.2% 0.1
pkg/pod/script.go 99.0% 99.1% 0.1

tekton-robot avatar Feb 14 '24 07:02 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/entrypoint/main.go 11.6% 12.7% 1.1
pkg/apis/pipeline/v1/taskrun_types.go 81.4% 82.8% 1.5
pkg/apis/pipeline/v1/taskrun_validation.go 96.9% 97.0% 0.1
pkg/apis/pipeline/v1beta1/taskrun_conversion.go 91.9% 92.1% 0.2
pkg/apis/pipeline/v1beta1/taskrun_types.go 82.3% 83.6% 1.3
pkg/apis/pipeline/v1beta1/taskrun_validation.go 96.9% 97.1% 0.1
pkg/entrypoint/entrypointer.go 89.0% 88.9% -0.1
pkg/pod/entrypoint.go 94.1% 94.2% 0.1
pkg/pod/script.go 99.0% 99.1% 0.1

tekton-robot avatar Feb 14 '24 07:02 tekton-robot

/test pull-tekton-pipeline-integration-tests

chengjoey avatar Feb 14 '24 07:02 chengjoey

@chengjoey @chitrangpatel I think this only needs a second reviewer, correct? If so I'll add it to my review list

afrittoli avatar Feb 26 '24 12:02 afrittoli

@chengjoey @chitrangpatel I think this only needs a second reviewer, correct? If so I'll add it to my review list right, please review this🙏

chengjoey avatar Feb 27 '24 03:02 chengjoey

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/entrypoint/main.go 11.6% 12.7% 1.1
pkg/apis/pipeline/v1/taskrun_types.go 81.4% 82.8% 1.5
pkg/apis/pipeline/v1/taskrun_validation.go 96.9% 97.1% 0.1
pkg/apis/pipeline/v1beta1/taskrun_conversion.go 92.8% 92.9% 0.1
pkg/apis/pipeline/v1beta1/taskrun_types.go 82.3% 83.6% 1.3
pkg/apis/pipeline/v1beta1/taskrun_validation.go 96.9% 97.1% 0.1
pkg/entrypoint/entrypointer.go 86.7% 86.8% 0.1
pkg/pod/entrypoint.go 94.1% 94.2% 0.1
pkg/pod/script.go 99.0% 99.1% 0.1

tekton-robot avatar Apr 12 '24 02:04 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/entrypoint/main.go 11.6% 12.7% 1.1
pkg/apis/pipeline/v1/taskrun_types.go 81.4% 82.8% 1.5
pkg/apis/pipeline/v1/taskrun_validation.go 96.9% 97.1% 0.1
pkg/apis/pipeline/v1beta1/taskrun_conversion.go 92.8% 92.9% 0.1
pkg/apis/pipeline/v1beta1/taskrun_types.go 82.3% 83.6% 1.3
pkg/apis/pipeline/v1beta1/taskrun_validation.go 96.9% 97.1% 0.1
pkg/entrypoint/entrypointer.go 86.7% 86.8% 0.1
pkg/pod/entrypoint.go 94.1% 94.2% 0.1
pkg/pod/script.go 99.0% 99.1% 0.1

tekton-robot avatar Apr 12 '24 02:04 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/entrypoint/main.go 11.6% 12.7% 1.1
pkg/apis/pipeline/v1/taskrun_types.go 81.4% 82.8% 1.5
pkg/apis/pipeline/v1/taskrun_validation.go 96.9% 97.1% 0.1
pkg/apis/pipeline/v1beta1/taskrun_conversion.go 92.8% 92.9% 0.1
pkg/apis/pipeline/v1beta1/taskrun_types.go 82.3% 83.6% 1.3
pkg/apis/pipeline/v1beta1/taskrun_validation.go 96.9% 97.1% 0.1
pkg/entrypoint/entrypointer.go 86.7% 86.8% 0.1
pkg/pod/entrypoint.go 94.1% 94.2% 0.1
pkg/pod/script.go 99.0% 99.1% 0.1

tekton-robot avatar Apr 12 '24 03:04 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
cmd/entrypoint/main.go 11.6% 12.7% 1.1
pkg/apis/pipeline/v1/taskrun_types.go 81.4% 82.8% 1.5
pkg/apis/pipeline/v1/taskrun_validation.go 96.9% 97.1% 0.1
pkg/apis/pipeline/v1beta1/taskrun_conversion.go 92.8% 92.9% 0.1
pkg/apis/pipeline/v1beta1/taskrun_types.go 82.3% 83.6% 1.3
pkg/apis/pipeline/v1beta1/taskrun_validation.go 96.9% 97.1% 0.1
pkg/entrypoint/entrypointer.go 86.7% 86.8% 0.1
pkg/pod/entrypoint.go 94.1% 94.2% 0.1
pkg/pod/script.go 99.0% 99.1% 0.1

tekton-robot avatar Apr 12 '24 03:04 tekton-robot

@chengjoey can you please rebase when you get a chance?

chitrangpatel avatar Jul 16 '24 16:07 chitrangpatel

This needs to be rebased. Moving to the next release to give some more time. Please let us know otherwise.

chitrangpatel avatar Jul 17 '24 14:07 chitrangpatel

@chengjoey can you please rebase when you get a chance?

done~

chengjoey avatar Jul 17 '24 14:07 chengjoey

/lgtm

chitrangpatel avatar Jul 17 '24 14:07 chitrangpatel