pipeline icon indicating copy to clipboard operation
pipeline copied to clipboard

TEP-0120 cancel existing pipelineruns

Open chengjoey opened this issue 2 years ago • 5 comments

Changes

Add CRD Queue for tep 120 cancel existing pipelineruns

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • [ ] Has Docs included if any changes are user facing
  • [ ] Has Tests included if any functionality added or changed
  • [ ] Follows the commit message standard
  • [ ] Meets the Tekton contributor standards (including functionality, content, code)
  • [ ] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • [ ] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • [ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Add Queue CRD to limit the concurrency of a set of PipelineRun

chengjoey avatar Feb 06 '23 15:02 chengjoey

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign lbernick after the PR has been reviewed. You can assign the PR to them by writing /assign @lbernick in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot avatar Feb 06 '23 15:02 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/pipelinerun_types.go 88.3% 85.0% -3.3

tekton-robot avatar Feb 06 '23 16:02 tekton-robot

The following is the coverage report on the affected files. Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/pipelinerun_types.go 88.3% 85.0% -3.3

tekton-robot avatar Feb 06 '23 16:02 tekton-robot

@chengjoey: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-tekton-pipeline-beta-integration-tests b6d894f1a8cf4f3bd0fcbeb82afcf0a84b9dad3a link true /test pull-tekton-pipeline-beta-integration-tests
pull-tekton-pipeline-integration-tests b6d894f1a8cf4f3bd0fcbeb82afcf0a84b9dad3a link true /test pull-tekton-pipeline-integration-tests
pull-tekton-pipeline-alpha-integration-tests b6d894f1a8cf4f3bd0fcbeb82afcf0a84b9dad3a link true /test pull-tekton-pipeline-alpha-integration-tests
pull-tekton-pipeline-unit-tests b6d894f1a8cf4f3bd0fcbeb82afcf0a84b9dad3a link true /test tekton-pipeline-unit-tests
pull-tekton-pipeline-build-tests b6d894f1a8cf4f3bd0fcbeb82afcf0a84b9dad3a link true /test pull-tekton-pipeline-build-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

tekton-robot avatar Feb 06 '23 16:02 tekton-robot

/kind feature

chengjoey avatar Feb 06 '23 16:02 chengjoey

@chengjoey: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot avatar Feb 15 '23 10:02 tekton-robot

TEP-0120 is not yet implementable, please reopen when we agree on a way forward and mark it implementable

(triaging old pull requests)

jerop avatar Apr 20 '23 13:04 jerop