pipeline
pipeline copied to clipboard
tektoncd
Ring buffer for credential filter
Changes
A ring buffer for the credential filter implemented in https://github.com/tektoncd/pipeline/pull/4837
It was decided to split it out from the original pull request to reduce the complexity of the pull requests.
The ring buffer is needed to buffer the outgoing logstream before printing it out to be able to check for any known secrets and redact them from the printed logs.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
- [ x] Has Docs included if any changes are user facing
- [x ] Has Tests included if any functionality added or changed
- [x ] Follows the commit message standard
- [ x] Meets the Tekton contributor standards (including functionality, content, code)
- [x ] Has a kind label. You can add one by adding a comment on this PR that contains
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep - [x ] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
- [x ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release
Release Notes
NONE
Hi @Useurmind. Thanks for your PR.
I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/credentials/filter/ring_buffer.go | Do not exist | 100.0% |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/credentials/filter/ring_buffer.go | Do not exist | 100.0% |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/credentials/buffer/ring_buffer.go | Do not exist | 95.5% |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/credentials/buffer/ring_buffer.go | Do not exist | 95.5% |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/credentials/buffer/ring_buffer.go | Do not exist | 95.5% |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/credentials/buffer/ring_buffer.go | Do not exist | 95.7% |
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/credentials/buffer/ring_buffer.go | Do not exist | 95.7% |
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: lbernick
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [lbernick]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@Useurmind there are some unaddressed comments from @lbernick, please address them then I'll take another look
/assign
(triaging old pull requests)
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.
/lifecycle stale
Send feedback to tektoncd/plumbing.
/test pull-tekton-pipeline-build-tests /test pull-tekton-pipeline-go-coverage
The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report
| File | Old Coverage | New Coverage | Delta |
|---|---|---|---|
| pkg/credentials/buffer/ring_buffer.go | Do not exist | 95.7% |
@Useurmind: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-tekton-pipeline-build-tests | 6c3f459cbfa742403cf87da727c611a45c13cfa9 | link | true | /test pull-tekton-pipeline-build-tests |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
@Useurmind thank you for the contribution, feel free to reopen this PR when you revisit this work
(cleaning up old pull requests)