pipeline icon indicating copy to clipboard operation
pipeline copied to clipboard

[TEP-0094] Feedback/beta release for taskRun.spec.stepSpecs and taskRun.spec.sidecarSpecs

Open lbernick opened this issue 3 years ago • 13 comments

This issue tracks bringing step and sidecar overrides to beta, and any feedback on or issues with this feature.

We'll be renaming these fields to stepSpecs and sidecarSpecs in v1 and can optionally do so as well if/when we enable this feature in v1beta1 without enable-api-fields set to alpha.

lbernick avatar Sep 13 '22 16:09 lbernick

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale with a justification. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

tekton-robot avatar Dec 12 '22 17:12 tekton-robot

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten with a justification. Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with /close with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

tekton-robot avatar Jan 11 '23 17:01 tekton-robot

If we can change the names here can we just use steps and sidecars. The Specs or Overrides word does not add anything and really is not making things less confusing about what you can and can't do.

skaegi avatar Jan 30 '23 18:01 skaegi

@skaegi This feature was actually renamed to stepSpecs and sidecarSpecs in the v1 API (https://github.com/tektoncd/community/blob/main/teps/0096-pipelines-v1.md#api-changes) for consistency with taskRunSpecs in PipelineRun

lbernick avatar Jan 30 '23 18:01 lbernick

I fully understand... wish that was just taskRuns too but admit the ship has sailed there. With that said I definitely think that Specs is better than Overrides and indeed more consistent.

skaegi avatar Jan 30 '23 21:01 skaegi

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen with a justification. Mark the issue as fresh with /remove-lifecycle rotten with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

tekton-robot avatar Mar 08 '23 17:03 tekton-robot

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen with a justification. Mark the issue as fresh with /remove-lifecycle rotten with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot avatar Mar 08 '23 17:03 tekton-robot

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale with a justification. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

tekton-robot avatar Jun 06 '23 21:06 tekton-robot

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten with a justification. Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with /close with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

tekton-robot avatar Jul 06 '23 21:07 tekton-robot

@lbernick Think this is still an issue, can you remove lifecycle/rotten please?

jimmyjones2 avatar Jul 07 '23 07:07 jimmyjones2

/lifecycle frozen

vdemeester avatar Jul 07 '23 08:07 vdemeester

/assign @khrm

khrm avatar May 29 '24 17:05 khrm

Let's add this to the milestone for v0.61.0 @chitrangpatel @vdemeester

PS: I wrongly pinged you guys on some other issue.

khrm avatar May 29 '24 17:05 khrm