community icon indicating copy to clipboard operation
community copied to clipboard

TEP-0085: Per-Namespace Controller Configuration [Proposal]

Open leiyanggz opened this issue 3 years ago • 9 comments

In TEP-0085 we proposed the support for overriding tekton-pipelines-controller's configuration on a per-namespace basis.

In this pull request, we include the proposal to configure the feature-flags configuration per namespace which is implemented in Tekton Pipelines Pull Request #4499

In summary, we propose enabling the controller's feature flags configuration per namespace via a new feature-flags ConfigMap in each of the candidate namespaces to override the properties defined in the feature-flags ConfigMap in the default system namespace, and the candidate namespaces are included in a new environment variable in the tekton-pipelines-controller.

leiyanggz avatar Jan 24 '22 22:01 leiyanggz

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign khrm You can assign the PR to them by writing /assign @khrm in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot avatar Jan 24 '22 22:01 tekton-robot

thank you @leiyanggz 😸

/assign

cc @sbwsg @vdemeester @pritidesai @dibyom (from the problem statement - https://github.com/tektoncd/community/pull/506)

jerop avatar Jan 24 '22 22:01 jerop

thank you @leiyanggz 👍 /assign

pritidesai avatar Jan 25 '22 19:01 pritidesai

Please add yourself as author and set the status to implementable:

status: implementable
title: Per-Namespace Controller Configuration
creation-date: '2021-08-25'
last-updated: '2022-01-24'
authors:
- '@sbwsg'
- '@jerop'
- '@leiyanggz'

pritidesai avatar Jan 25 '22 19:01 pritidesai

/kind tep

vdemeester avatar Jan 27 '22 08:01 vdemeester

@leiyanggz - please join us in one of the API WG on Mondays 12pm ET to discuss the review comments in this TEP and move it forward, happy to schedule an ad-hoc meeting if the time doesn't work for you, please let us know :)

jerop avatar Mar 14 '22 11:03 jerop

/test pull-community-teps-lint

afrittoli avatar Mar 21 '22 16:03 afrittoli

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale with a justification. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

tekton-robot avatar Jun 19 '22 17:06 tekton-robot

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten with a justification. Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with /close with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

tekton-robot avatar Jul 19 '22 17:07 tekton-robot

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen with a justification. Mark the issue as fresh with /remove-lifecycle rotten with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

tekton-robot avatar Aug 24 '22 16:08 tekton-robot

@tekton-robot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen with a justification. Mark the issue as fresh with /remove-lifecycle rotten with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot avatar Aug 24 '22 16:08 tekton-robot

I will carry this one 😇

vdemeester avatar Aug 24 '22 18:08 vdemeester