community icon indicating copy to clipboard operation
community copied to clipboard

TEP-0157 Retention Policy for Tekton Results

Open khrm opened this issue 1 year ago • 7 comments

khrm avatar Jul 22 '24 11:07 khrm

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please ask for approval from khrm after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot avatar Jul 22 '24 11:07 tekton-robot

/test pull-community-teps-lint

khrm avatar Jul 22 '24 11:07 khrm

@khrm: No presubmit jobs available for tektoncd/community@main

In response to this:

/test pull-community-teps-lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot avatar Jul 22 '24 11:07 tekton-robot

/assign @avinal @enarha @sayan-biswas

khrm avatar Jul 24 '24 11:07 khrm

/assign @vdemeester

khrm avatar Jul 24 '24 11:07 khrm

@khrm I wanna know if the retention policy under TektonResults component is configurable via TektonConfig CR? Like this

result:
    disabled: false
    is_external_db: false
    options:
      configMaps:
        config-results-retention-policy:
          data:
            runAt: "5 5 * * 0"
            maxRetention: "15"

This RedHat openshift doc here says that we can set maxRetention field this way.

amir-badar avatar May 16 '25 16:05 amir-badar

@amir-badar Yes, it's configurable using that, but we are changing maxRetention to defautlRetention. maxRetention will still work, but it's deprecated.

khrm avatar Aug 27 '25 19:08 khrm

One thing I find missing is how the deletion of logs happens. The TEP explains how data is deleted from the DB, please add a short description how that's connected to the logs deletion. The rest is LGTM.

enarha avatar Aug 28 '25 11:08 enarha

@enarha Sure. I would add that part also.

khrm avatar Sep 04 '25 12:09 khrm