GameLib.NET icon indicating copy to clipboard operation
GameLib.NET copied to clipboard

Published 20 hours ago • verified publisher icon tekgator

Broken Battle.net launch strings

Open JamesCJ60 opened this issue 2 years ago • 5 comments

Hi, I came across a bug when using .LaunchString with Battle.net games.

With the latest release, it currently returns --game=PRO instead of --exec="launch Pro", etc.

JamesCJ60 avatar Apr 03 '23 01:04 JamesCJ60

you beat me to this, was going to submit this issue

project-sbc avatar Apr 03 '23 10:04 project-sbc

Additonally.. the demo should account for a battle.net game having battle.net launched. If battle net is not already running that must be started first and fully loaded before running that launch command

project-sbc avatar Apr 03 '23 11:04 project-sbc

Hi, I came across a bug when using .LaunchString with Battle.net games.

With the latest release, it currently returns --game=PRO instead of --exec="launch Pro", etc.

@JamesCJ60 sounds like an easy bugfix but unfortunately I'm currently traveling. Will have a look when back. If you like feel free to submit a PR.

tekgator avatar Apr 15 '23 12:04 tekgator

Additonally.. the demo should account for a battle.net game having battle.net launched. If battle net is not already running that must be started first and fully loaded before running that launch command

I would say I'm not worried about it to much as it is just a DEMO app. This should be of course considered when implementing the library in any app.

tekgator avatar Apr 15 '23 12:04 tekgator

No problem! At least this note here could help someone later 😁

Get Outlook for iOShttps://aka.ms/o0ukef

From: Patrick Weiss @.> Sent: Saturday, April 15, 2023 8:46:39 AM To: tekgator/GameLib.NET @.> Cc: project-sbc @.>; Comment @.> Subject: Re: [tekgator/GameLib.NET] Broken Battle.net launch strings (Issue #19)

Additonally.. the demo should account for a battle.net game having battle.net launched. If battle net is not already running that must be started first and fully loaded before running that launch command

I would say I'm not worried about it to much as it is just a DEMO app. This should be of course considered when implementing the library in any app.

— Reply to this email directly, view it on GitHubhttps://github.com/tekgator/GameLib.NET/issues/19#issuecomment-1509779932, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ASZ4DJMBOTZFVCZMJPRCS3LXBKKC7ANCNFSM6AAAAAAWQVSZEU. You are receiving this because you commented.Message ID: @.***>

project-sbc avatar Apr 15 '23 15:04 project-sbc